Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for closing response stream #452

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Improve documentation for closing response stream #452

merged 1 commit into from
Apr 15, 2022

Conversation

clue
Copy link
Member

@clue clue commented Apr 14, 2022

Builds on top of #188 and #315
Refs #451

@clue clue added this to the v1.7.0 milestone Apr 14, 2022
@clue clue requested a review from WyriHaximus April 14, 2022 11:37
@clue clue mentioned this pull request Apr 14, 2022
Closed
@clue
Copy link
Member Author

clue commented Apr 14, 2022

For the reference: Unrelated HHVM build error is being addressed with #450

WyriHaximus
WyriHaximus approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WyriHaximus WyriHaximus merged commit 4862e84 into reactphp:1.x Apr 15, 2022
@clue clue deleted the close-streaming-response branch April 16, 2022 08:47
@yadaiio yadaiio mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@SimonFrings SimonFrings SimonFrings approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @WyriHaximus @SimonFrings