-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Mac OS X on Travis #130
Conversation
Squashed by @clue, originally from reactphp#124
I've updated this to skip platform-specific (Linux) tests on other platforms (Mac OS X). This is now ready for review |
Alternatively, you could mark the tests with |
These two tests specifically test system behavior ("how does the server side react to when a client connection is started and aborted immediately without waiting for the connection to be fully established?") and do not really test things specific to this library at all. We know this is how Linux behaves but do not have any reliable source for other platforms, so I think it makes sense to just skip this for now other platforms until we have a better understanding of this. Our library is known to work perfectly fine on Mac OS X and I think we should emphasize this (failing system specific tests give a wrong impression here). However, our resources to test this on other platforms are limited, I for one for not have a Mac at hand. Given how long this has gone unnoticed, I think it should be sufficient to rely on Travis to spot future regressions here. @andig I think using a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WyriHaximus I don't really have a use for this unless anybody brings up any issues, but if you feel it's worth it, I'd say for got it 👍 |
Squashed by @clue, originally from #124