Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis config to test against legacy PHP 5.3 again #162

Merged
merged 1 commit into from
May 6, 2018

Conversation

clue
Copy link
Member

@clue clue commented May 5, 2018

Just noticed that legacy PHP 5.3 does not show up in the Travis build log any more while working on #161. I'm not suggesting this is a particularly important version, but then again fixing this was somewhat trivial. Apparently, this was caused by a duplicate YAML definition in #130 (yey).

@clue
Copy link
Member Author

clue commented May 6, 2018

I've just updated this to fix the failing test case (on PHP 5.3 only) that was introduced via #146 :shipit:

@WyriHaximus WyriHaximus merged commit e8e53d6 into reactphp:master May 6, 2018
@clue clue deleted the travis branch May 6, 2018 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants