Add support for Unix domain sockets (UDS) #17

RafaelKa · 2015-06-02T14:42:51Z

This change adds support for unix domain socket transport for using unix:// for connections.

This change adds support for unix domain socket transport for using unix:// and udg:// for connections.

staabm · 2015-06-02T14:50:03Z

src/Server.php

@@ -18,14 +18,26 @@ public function __construct(LoopInterface $loop)

    public function listen($port, $host = '127.0.0.1')
    {
-        if (strpos($host, ':') !== false) {
+        $localSocket = '';
+        if (filter_var($host, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {


composer.json should reflect that react requires ext-filter

@staabm
This ext. is since PHP 5.2 enabled by default. http://php.net/manual/en/filter.installation.php
I see many methods from multiple PHP ext.s used in react and no entry in composer.json for them.
What is the difference by ext-filter?

Which extensions does React use that aren't declared?

@cboden f.x. PCRE (for preg_replace) is like Filter enabled per default to.

Is it maybe better to preg_match both instead of using filter?

This ext. is since PHP 5.2 enabled by default

@RafaelKa you neverthelesss should declar it, because a lot of people - especially on production servers - use non-default builds (``--disable-all`) which are stripped down to the very least for performance and security reasons.

Which extensions does React use that aren't declared?

@cboden from within this code-window I would say e.g. ext-pcre

you neverthelesss should declar it

I agree, all dependencies should explicitly be defined (and kept to a minimum for obvious reasons). Though in this case, have you checked PHP's installation instructions? (http://php.net/manual/en/pcre.installation.php and http://php.net/manual/en/filter.installation.php)

Which extensions does React use that aren't declared?

None that I'm aware of. It anybody happens to spot one, please file an issue or even better a PR in the relevant component :-)

Required ext-filter for validating ip v4 and v6 addresses to composer.json added

clue · 2015-06-02T15:53:54Z

👍 on adding support for Unix domain sockets!

However, I'm not particularly happy with the current interface:

$socket->listen(0, 'unix:///var/tmp/demo.sock');

See #6 for an alternative implementation (with a cleaner API IMHO), which involves a BC break.

RafaelKa · 2015-06-02T16:00:19Z

@clue
i thought on this solution to, but i think this is not courteous for community. To many people are using this library, therefore i did this backward compatible patch.
However i would prefer #6 at all ;).

UDG sockets are based on datagrams instead of streams of bytes and already a part of React's datagram component.

RafaelKa · 2015-06-02T18:40:58Z

"For UNIX domain sockets, file and directory permissions restrict which processes on the host can open the file, and thus communicate with the server. Therefore, UNIX domain sockets provide an advantage over Internet sockets (to which anyone can connect, unless extra authentication logic is implemented)."

What do you think about setting permissions on uds file at creation time?

1: Is current pull request good as is. Make new pull request after this one is merged
2: push https://gist.github.com/RafaelKa/33856a11023455653af8 in this pull request immediately
significant rows are: 19, 28, 41-43

clue · 2015-06-07T11:53:12Z

What do you think about setting permissions on uds file at creation time?

I think it makes sense to have this feature. However, I'm not a big fan of the API, so perhaps we can postpone this until we find a better API? The Server implements the ServerInterface, and adding UDS parameters to the global ServerInterface sounds odd IMHO.

RafaelKa · 2015-06-08T11:38:19Z

@clue, what do you mean with better API?
is WIP for new API?
becomes this lib new structure?

RafaelKa · 2015-12-10T22:34:08Z

You added support for Unix domain sockets (UDS) in reactphp/socket-client, i think currently it's the time to go with UDS on serverside!

Are in this PR some deficits present, which need to be fixed?
Or is this PR for garbage and i can forget about it and try something other again without new dependencies?

mikegioia · 2016-01-14T03:55:28Z

@RafaelKa @cboden Is there anything holding up the merge of this PR? I'd love to be able to use this without forking :D 🙏

RafaelKa · 2016-01-14T10:17:17Z

i can decide here nothing :-P only cboden can do that, not sure but i think it is on hold, because new dependency(filter) is here. If it is so, we must do the same with regex instead of filter.

cboden · 2016-01-14T14:55:28Z

I think I would prefer a separate interface as opposed to string parsing. The string parsing is at a higher level of the chain (conceptually) in that's it's a URI whereas this lib is about socket (lower level) I/O.

I think a helper function somewhere (wrapper lib maybe) would be a better place to do string parsing and call the correlating API of TCP or Unix socket.

Thoughts @clue?

mikegioia · 2016-01-14T15:07:06Z

Is it possible to mimic behaviour from Socket-Connection with, say, a UnixServer class (leaving the Server class alone)?

$loop = React\EventLoop\Factory::create();
$socket = new React\Socket\UnixServer( $loop );
$socket->on( 'connection', function ($conn) { ... } );

marcj · 2016-03-22T23:34:26Z

Can this PR be merged? What's missing?

clue · 2016-05-20T14:17:43Z

Can this PR be merged? What's missing?

Several issues have been raised in this ticket, besides it currently has a merge conflict.

Is it possible to mimic behaviour from Socket-Connection with, say, a UnixServer class (leaving the Server class alone)?

I think this makes sense 👍

However, I'm not particularly happy with the current interface:

$socket->listen(0, 'unix:///var/tmp/demo.sock');

I still think this doesn't make much sense. Ticket #19 suggests an alternative API.

clue · 2017-10-10T10:32:52Z

I'm closing this for now as it hasn't received any input in a while and there is now a new PR #120 to implement this by @andig. Thank you for your effort and filing this PR! If you feel this PR has been closed prematurely and this problem persists, please come back with more details and we can reopen this 👍

Add support for Unix domain sockets,

5267a13

This change adds support for unix domain socket transport for using unix:// and udg:// for connections.

staabm reviewed Jun 2, 2015
View reviewed changes

require ext-filter for validating ip v4 and v6

97a838c

Required ext-filter for validating ip v4 and v6 addresses to composer.json added

remove udg://

0932e9b

UDG sockets are based on datagrams instead of streams of bytes and already a part of React's datagram component.

clue mentioned this pull request Sep 19, 2015

[Server] Add support for Unix domain sockets (UDS) #25

Closed

RafaelKa mentioned this pull request Dec 21, 2015

Different api by client transport providers voryx/Thruway#165

Closed

rcambien mentioned this pull request Apr 4, 2016

Add a more generic bind() method to allow Unix socket server #34

Closed

clue added the new feature label Nov 21, 2016

clue mentioned this pull request Jan 17, 2017

Replace listen() call with URIs passed to constructor #61

Merged

clue mentioned this pull request Jan 26, 2017

Return full remote address instead of only IP #65

Merged

clue mentioned this pull request Feb 5, 2017

Replace getPort() with getAddress() #67

Merged

clue closed this Oct 10, 2017

This was referenced Nov 24, 2021

Support platforms without ext-filter (Call to undefined function LeProxy\LeProxy\filter_var()) leproxy/leproxy#80

Open

Avoid dependency on ext-filter reactphp/dns#185

Merged

clue mentioned this pull request Dec 6, 2021

Avoid dependency on ext-filter #279

Merged

This was referenced Dec 6, 2021

Avoid dependency on ext-filter reactphp/datagram#45

Merged

Avoid dependency on ext-filter clue/reactphp-ssh-proxy#31

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Unix domain sockets (UDS) #17

Add support for Unix domain sockets (UDS) #17

RafaelKa commented Jun 2, 2015

staabm Jun 2, 2015

RafaelKa Jun 2, 2015

cboden Jun 2, 2015

RafaelKa Jun 2, 2015

staabm Jun 2, 2015

clue Jun 7, 2015

clue commented Jun 2, 2015

RafaelKa commented Jun 2, 2015

RafaelKa commented Jun 2, 2015

clue commented Jun 7, 2015

RafaelKa commented Jun 8, 2015

RafaelKa commented Dec 10, 2015

mikegioia commented Jan 14, 2016

RafaelKa commented Jan 14, 2016

cboden commented Jan 14, 2016

mikegioia commented Jan 14, 2016

marcj commented Mar 22, 2016

clue commented May 20, 2016

clue commented Oct 10, 2017

Add support for Unix domain sockets (UDS) #17

Add support for Unix domain sockets (UDS) #17

Conversation

RafaelKa commented Jun 2, 2015

staabm Jun 2, 2015

Choose a reason for hiding this comment

RafaelKa Jun 2, 2015

Choose a reason for hiding this comment

cboden Jun 2, 2015

Choose a reason for hiding this comment

RafaelKa Jun 2, 2015

Choose a reason for hiding this comment

staabm Jun 2, 2015

Choose a reason for hiding this comment

clue Jun 7, 2015

Choose a reason for hiding this comment

clue commented Jun 2, 2015

RafaelKa commented Jun 2, 2015

RafaelKa commented Jun 2, 2015

clue commented Jun 7, 2015

RafaelKa commented Jun 8, 2015

RafaelKa commented Dec 10, 2015

mikegioia commented Jan 14, 2016

RafaelKa commented Jan 14, 2016

cboden commented Jan 14, 2016

mikegioia commented Jan 14, 2016

marcj commented Mar 22, 2016

clue commented May 20, 2016

clue commented Oct 10, 2017