Replace getPort() with getAddress() #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getPort()
currently only returns the "port" part and explicitly omits the listening IP. This has been documented as of v0.4.4 and has in fact been like this ever since this method has been added.This PR replaced this method with a
getAddress()
method that it returns the full remote address, i.e. IP and port.This is obviously a BC break, so I've made sure to add documentation on how to get only the port from the full address with a one-liner.
Empirical evidence seems to suggest the old
getPort()
method isn't used that much and is mostly used in a context where the full URI likely makes more sense anyway. For TCP/IP based servers, the full URI contains the port and with the above one-liner this switch should be easy.There are plenty of reasons, let me try to list a few here:
connect($uri)
instead ofcreate($host, $port)
reactphp-legacy/socket-client#74)