Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancelling happy eyeballs to stop timer, fix rejection reason and simplify timer logic #225

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

clue
Copy link
Member

@clue clue commented Mar 11, 2020

This changeset fixes a leftover timer reference when cancelling the happy eyeballs connection attempt. Additionally, this increases test coverage to 100% and significantly improves test times (27s->5s).

Builds on top of #224

@clue clue added the bug label Mar 11, 2020
@clue clue added this to the v1.4.0 milestone Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants