Support setting buffer size to null (infinite) #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just rebased this to resolve the merge conflict introduced by #39 |
|
I've just rebased this to resolve the merge conflict introduced by #40 |
|
LGTM |
|
FYI: facebook/hhvm#6921. |
Thanks for link 👍 I've updated the documentation to be a bit clearer about what
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no effect by default and can be triggered by setting
bufferSizetonull.This can result in huge performance improvements without causing any memory issues if the buffer size is limited by the underlying OS anyway (such as when reading from a TCP/IP socket).
Also, this can be used to avoid some SSL/TLS hackery in our socket-client component: https://github.com/reactphp/socket-client/blob/f905ec2a576b1242b10d5c1dbd2f0eb4fcea7f0c/src/SecureStream.php#L44