Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting buffer size to null (infinite) #42

Merged
merged 3 commits into from
Nov 9, 2016

Conversation

clue
Copy link
Member

@clue clue commented Mar 13, 2016

This has no effect by default and can be triggered by setting bufferSize to null.

This can result in huge performance improvements without causing any memory issues if the buffer size is limited by the underlying OS anyway (such as when reading from a TCP/IP socket).

Also, this can be used to avoid some SSL/TLS hackery in our socket-client component: https://github.com/reactphp/socket-client/blob/f905ec2a576b1242b10d5c1dbd2f0eb4fcea7f0c/src/SecureStream.php#L44

@clue
Copy link
Member Author

clue commented Mar 15, 2016

I've just rebased this to resolve the merge conflict introduced by #39 :shipit:

@clue
Copy link
Member Author

clue commented Mar 21, 2016

I've just rebased this to resolve the merge conflict introduced by #40 :shipit:

@WyriHaximus
Copy link
Member

LGTM :shipit:

@rybakit
Copy link

rybakit commented Mar 24, 2016

FYI: facebook/hhvm#6921.

@clue
Copy link
Member Author

clue commented May 20, 2016

FYI: facebook/hhvm#6921.

Thanks for link 👍 I've updated the documentation to be a bit clearer about what null means.

:shipit: ?

@clue clue added this to the v0.4.5 milestone Aug 14, 2016
@cboden cboden merged commit c1a71ec into reactphp:master Nov 9, 2016
@clue clue deleted the read-infinite branch November 13, 2016 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants