Should we release 0.70.2?

[dmytrorykun]

Released - please refer to #36 for followups

Current Release: 0.70.1

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

---

Issues we are aware of

1. Hermes transforms not enabled by default when creating a new 0.70.0 project facebook/react-native#34656
2. Unable to build with XCode 14.0 facebook/react-native#34673
3. Animated.Value resets styles when detached on RN 0.70.0 facebook/react-native#34665

List of qualified picks

1. facebook/react-native@be7c50f
2. facebook/react-native@3d7e138
3. facebook/react-native@f164556

Local commits to backport to main

[renchap]

Animated has a broken behaviour on 0.70: facebook/react-native#34665
It breaks the drawer implementation in react-native-gesture-handler for example and is a blocker for upgrading to 0.70 in multiple apps.

[gabrieldonadel]

I just noticed that we missed facebook/react-native@be7c50f when we cherry-picked facebook/react-native@4b9382c on 0.70.1 which is required otherwise https://github.com/facebook/react-native/blob/03cb5aca3f5b8594287608265d4bde7104f07b87/Libraries/Components/Keyboard/KeyboardAvoidingView.js#L88 throws an undefined is not a function error when "Prefer Cross-Fade Transitions" is enabled

[fungilation]

Reproducing same. On iOS 15.7, iPhone 12

[cortinico]

This is not the thread to report issues but to ask for pick requests, for fixes that landed on master.

[billnbell]

then lets add facebook/react-native@be7c50f

[tido64]

Sorry, this thread is not for feature requests. New features can break things, and we don't want to risk that in patch releases. Please see What is a qualified pick request? from the description in OP. Sorry, it looks like we do need it because we cherry-picked something else that broke it here: #34 (comment)

[kelset]

we need to realign the deps: facebook/react-native#34714 (to latest 0.72.3)

[kelset]

also bump CLI

[kelset]

PR: facebook/react-native#34803

[kelset]

commit: facebook/react-native@f164556

[Kudo]

hope we could also pick this facebook/react-native@3d7e138

[cortinico]

As suggested by @kelset is maybe better to don't bump AGP versions in point releases. As this fixes just an annoyance, I think it's probably fine to don't bump it.

[evan1715]

yeah, you can use 0.69.6 instead of trying to use 0.70.1 or 0.70.2. if you're having hermes compiling issues on iOS from 0.70.1 with xcode, like i am waiting for 0.70.2 to fix it before releasing the app, then 0.69.6 is probably best. if you're not facing any hermes issues, then the latest version of anything is typically the best.

[cortinico]

Sorry but this not the correct please to ask questions about which version to use, as that is probably specific to your environment. Please consider posting this on Stackoverflow.