Replies: 12 comments 16 replies
-
|
A TS fix facebook/react-native@23607ae |
Beta Was this translation helpful? Give feedback.
-
|
Not extremely crucial, but this enables users on 0.71+ to build from source the Android artifacts if needed, instead of pulling those from Maven Central:
That's more of an edge case use case, but could be useful for someone |
Beta Was this translation helpful? Give feedback.
-
|
That makes sense. Thanks for explaining 😊 |
Beta Was this translation helpful? Give feedback.
-
|
Should this then be backported all the way down to 0.69? You've changed the instructions and people may not have upgraded to 0.71 yet. |
Beta Was this translation helpful? Give feedback.
-
|
So sadly the "build from source" page is not versioned, and I believe it's fine as it is (as I consider it an "unsupported" build path). We don't test it and we don't encourage users moving over to that build path. It should be something only for advanced users as the build is more likely to fail due to the complexity of our build logic. For 0.71+ this is more crucial as we have artifacts on Maven Central instead of the If we wish, we can backport my commit down to 0.69, that's not a major change. It just makes it easier to |
Beta Was this translation helpful? Give feedback.
-
|
EDIT: I've added another commit to cherry-pick (I've edited my original message) as I got a report of a broken build from source on nightlies which I wanted to fix: facebook/react-native@f8d8764 |
Beta Was this translation helpful? Give feedback.
-
|
EDIT: while pickign those with @kelset I've realized we missed a commit which is necessary as well (facebook/react-native#36128). I've included it in my original comment. |
Beta Was this translation helpful? Give feedback.
-
|
This fixes a bug for relative paths with (And requires a bump of RNGP) |
Beta Was this translation helpful? Give feedback.
-
|
a customer reported a slow hermes bundle issue on android, which is similar to this issue. do you think whether it is feasible to land the fix on 0.71, though i think that fix comes with more feature-wise changes? |
Beta Was this translation helpful? Give feedback.
-
|
let's chat about this during the weekly sync |
Beta Was this translation helpful? Give feedback.
-
|
Since RN 0.71.0 went out with Terser as the default JS minifier for the first time (replacing Uglify-ES), we've had reports of and fixed two issues in source maps generated by Metro+Terser. The issues amount to source maps being (usually?) invalid in specific entries, and potentially incompatible with any tooling that inspects them - one known issue is that I released a Metro hotfix 0.73.8 with just those fixes over Metro 0.73.7 (currently distributed with RN 0.71.3). Due to exact version pinning of RNCLI and Metro, we'd need an RN patch release for these fixes to reach RN users. |
Beta Was this translation helpful? Give feedback.
-
|
Opened a PR to the 10.x branch of the CLI: react-native-community/cli#1841 |
Beta Was this translation helpful? Give feedback.
-
|
10.2.0 has been released with Metro 0.73.8. Opened a PR to pull this into Edit: Now merged. |
Beta Was this translation helpful? Give feedback.
-
|
thanks Rob 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
Should we pick facebook/hermes@059d085? Exists since 0.70. |
Beta Was this translation helpful? Give feedback.
-
|
Hey there, there is an issue in Hermes that prevents one from loading large, complex bundles in development. The change is to simply increase the max size of the stack. The change hasn't been merged yet but it targets the stable branch within Hermes for 0.71. My guess is some coordination needs to happen to first merge this then bump this in RN. I'm happy to help where ever needed. |
Beta Was this translation helpful? Give feedback.
-
|
looks like that commit wouldn't be enough: facebook/hermes#135 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
I know it looks that way but this commit is not the same as the commit referenced in that comment. facebook/hermes@03f2dff#diff-6c71d832d338aa663651a4747ab28c7de265ccc722fc2587d2749d18b69aa96cL118 actually removes the |
Beta Was this translation helpful? Give feedback.
-
|
facebook/react-native@c03de97 makes FlatList permissve of ArrayLike non-array data, which better matches the behavior of 0.70 when using that (e.g. |
Beta Was this translation helpful? Give feedback.
-
|
Maybe a bit late since this has already merged, but shouldn't the type be |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
https://github.com/facebook/react-native/pull/36323/files |
Beta Was this translation helpful? Give feedback.
-
|
Could this be included too? facebook/react-native#36340 |
Beta Was this translation helpful? Give feedback.
-
|
I tried including it but it triggers a conflict, so we'll skip it for now |
Beta Was this translation helpful? Give feedback.
-
Released, please refer to #59
Current Release: 0.71.3
Conversations on this thread are limited:
Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6
In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.
List of qualified picks
(from oldest to newest)
Hermes side: (ref GH action and docs)
Backport: Increase kMaxNumRegisters for RN 0.71 facebook/hermes#925Local commits to backport to main
Beta Was this translation helpful? Give feedback.
All reactions