NPM upgrade + Thorium ports #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #97 but doesn’t fix the overarching issue in Chromium. Also needs docs before being pushed into main.
Upgrade AccessibleDfa to 1.7
Npm upgrade
Audio now on its own so that value auto for width or height doesn’t break controls. Resolves #94
Forcing value of var instead of inherit to make sure it is applied in all conditions. Resolves #128
This module allows for the hiding of ruby annotations in CJK. Resolves #140
Tests for letter-spacing in CJK and hiding ruby annotations
Remove Japanese name settings as much as possible and add Postscripting name settings. Font order is basically based on the previous one.
Remove Japanese names as much as possible. Since MS fonts do not have anti-aliasing, try adjusting them to use BIZ UD Fonts, which are currently considered easy to read in Japanese Windows environments.
Fix japanese font settings
With fixed japanese fonts
Thorium ports: - it resolves Letter-spacing for japanese #136 - it resolves User setting to disable/hide ruby #140 - it fixes Width and height safeguards hide audio controls + video #94 - it fixes forcing "start" text alignment (left or right depending on document language) does not work with "inherit" #128
Trying to make life easier for contributors by automatically building dist stylesheets on push & PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
(Add x between brackets to check.)
What kind of change does this PR introduce? (Bug fix, feature, docs update, other)
This carries a couple of fixes (correcting Accessible DfA font rendering among others).
It also updates NPM env – and upgrades its dependencies.
Finally it implements Thorium changes that can be useful to all consumers of ReadiumCSS.
Specifically:
it resolves #136
it resolves #140
it fixes #94
it fixes #128
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Fixes should be straightforward and transparent for most apps, unless they already had something in place to fix these bugs.
New features i.e. hiding ruby annotation and letter-spacing in CJK languages, should obviously be implemented.
Other information:
This PR is meant to be the last version 1 of ReadiumCSS and will be tagged as such.
Given the extent of breaking changes and the new philosophy guiding decisions in the last months of development, it’s been decided to upgrade to version 2.