Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to open resource with linear=no #330

Closed
chrfalch opened this issue Aug 22, 2023 · 1 comment
Closed

Impossible to open resource with linear=no #330

chrfalch opened this issue Aug 22, 2023 · 1 comment

Comments

@chrfalch
Copy link
Contributor

Bug Report

This is a copy of the same issue in Kotlin-toolkit: readium/kotlin-toolkit#124

Added to create pull requests that refers to a valid issue in the repo.

chrfalch added a commit to chrfalch/swift-toolkit that referenced this issue Aug 22, 2023
To be able to implement alternative ways of internal links, like presenting it in a separate view, this commit adds a NavigatorDelegate method called `shouldNavigateToLink` that by default returns true - but can be overridden to signal to the caller that we've handled the resource outside of the regular flow.

This can be used to catch things like links to non-linear resources (Impossible to open resource with linear=no readium#330).
chrfalch added a commit to chrfalch/swift-toolkit that referenced this issue Aug 22, 2023
… EPubNavigationViewController

To be able to show non-linear resources this commit adds an optional and extra parameter to the EPubNavigationViewController which is by default set to be the publication's readingOrder.

This lets us show non-linear resources or navigate to internal resources in separate views. This can be used to solve issues like Impossible to open resource with linear=no readium#330.
@chrfalch
Copy link
Contributor Author

Closed by #331 and #332!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant