Added custom readingOrder to EPubNavigationViewController #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… EPubNavigationViewController To be able to show non-linear resources this commit adds an optional and extra parameter to the EPubNavigationViewController which is by default set to be the publication's readingOrder. This lets us show non-linear resources or navigate to internal resources in separate views. This can be used to solve issues like Impossible to open resource with linear=no readium#330.
CR: Removed adding readingOrder to deprecated constructor Co-authored-by: Mickaël Menu <mickael.menu@gmail.com>
…it instead of setting it to publication.readingOrder.
… reading order is set
chrfalch
commented
Aug 29, 2023
mickael-menu
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to show non-linear resources this commit adds an optional and extra parameter to the EPubNavigationViewController which is by default set to be the publication's readingOrder.
This lets us show non-linear resources or navigate to internal resources in separate views. This can be used to solve issues like Impossible to open resource with linear=no #330.