Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom readingOrder to EPubNavigationViewController #332

Merged
merged 9 commits into from
Aug 29, 2023
Merged

Added custom readingOrder to EPubNavigationViewController #332

merged 9 commits into from
Aug 29, 2023

Commits on Aug 22, 2023

  1. Added custom readingOrder as optional parameter when constructing the… 

    … EPubNavigationViewController

To be able to show non-linear resources this commit adds an optional and extra parameter to the EPubNavigationViewController which is by default set to be the publication's readingOrder.

This lets us show non-linear resources or navigate to internal resources in separate views. This can be used to solve issues like Impossible to open resource with linear=no readium#330.
    @chrfalch
    chrfalch committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    943e5d5 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Update Sources/Navigator/EPUB/EPUBNavigatorViewController.swift 

    CR: Removed adding readingOrder to deprecated constructor

Co-authored-by: Mickaël Menu <mickael.menu@gmail.com>
    @chrfalch @mickael-menu
    chrfalch and mickael-menu authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a8e3f8d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix/330-add-readingOrder-as-parameter-to-… 

    …epubnavigator
    @chrfalch
    chrfalch authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    7fa9122 View commit details
    Browse the repository at this point in the history

  3. CR: Moved readingOrder below initialLocator

    @chrfalch
    chrfalch committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    24c51f8 View commit details
    Browse the repository at this point in the history

  4. CR: Made readingOrder optional and added conditional test when using … 

    …it instead of setting it to publication.readingOrder.
    @chrfalch
    chrfalch committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4a9cda6 View commit details
    Browse the repository at this point in the history

  5. CR: locator is calculated without progression / positions when custom… 

    … reading order is set
    @chrfalch
    chrfalch committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    46ac687 View commit details
    Browse the repository at this point in the history

  6. CR: Removed use of readingOrder in deprecated constructor

    @chrfalch
    chrfalch committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2e163d3 View commit details
    Browse the repository at this point in the history

  7. Simplifications

    @mickael-menu
    mickael-menu committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f5fb2d6 View commit details
    Browse the repository at this point in the history

  8. Update auto-generated files

    @mickael-menu
    mickael-menu committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    cd3006a View commit details
    Browse the repository at this point in the history