fix: types #877
fix: types #877
Conversation
|
There was a problem hiding this comment.
looks like there's a type error on line 96 now?
| @@ -112,12 +112,12 @@ export const html = (text: string, opts = {}) => { | |||
| unimplemented('html export'); | |||
| }; | |||
|
|
|||
| const astProcessor = (opts = {}) => | |||
| const astProcessor = (opts: MdastOpts = { components: {} }) => | |||
There was a problem hiding this comment.
Can components get more specific or is it just Record<string, string>?
There was a problem hiding this comment.
I don't think so? It's a mapping of tag name to component body?
There was a problem hiding this comment.
might want to narrow it to Record<string, string> because right now it'll allow Record<string, unknown>
There was a problem hiding this comment.
oh my bad. MdastOpts is where components is defined, I misread the = there as : and thought you were typing opts: { components: {} }
There was a problem hiding this comment.
Thought I was about to have my type system shattered.
There was a problem hiding this comment.
nope im just a dumbass. carry on
|
This PR was released!🚀 Changes included in v6.75.0-beta.32 |
🧰 Changes
Fixes a bunch of types from the jsx-coercion PR.
🧬 QA & Testing