chore: profiling #936
Closed
chore: profiling #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jon Ursenbach <erunion@users.noreply.github.com>
feat: initial commit
Commits the dist directory, as well as emits types!
fix: dont raise
chore: mdx v1 build
| [![PR App][icn]][demo] | RM-9917 | | :--------------------: | :-----: | ## 🧰 Changes Adds the position data to variable nodes, oops. Useful in the editor. ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
| [![PR App][icn]][demo] | RM-9917 | | :--------------------: | :-----: | ## 🧰 Changes Adds `readme-variable` to the mdast for the editor to consume I found myself transforming `mdx` nodes in the editor and decided I should stick my existing convetion to do that in the library. ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
[![PR App][icn]][demo] | Fix RM-10049 :-------------------:|:----------: ## 🧰 Changes cleaner way to add/update image caption ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
[![PR App][icn]][demo] | Fix RM-10134 :-------------------:|:----------: ## 🧰 Changes Converts the rdmd-style `mdast` for the image and embed blocks to the new MDX components ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
[![PR App][icn]][demo] | Fix RM-XYZ :-------------------:|:----------: ## 🧰 Changes migration diffs had a lot of discrepancies, tightening things up ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
Reverts #922' forgot to push test fixes
[![PR App][icn]][demo] | Fix RM-XYZ :-------------------:|:----------: ## 🧰 Changes migration diffs had a lot of discrepancies, tightening things up (only v minor changes) ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
[![PR App][icn]][demo] | Fix RM-XYZ :-------------------:|:----------: ## 🧰 Changes Adding `className` to the ImageBlock type for passing the `className` from the component in the future. (also just adding trivial commit to kick off release) ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
[![PR App][icn]][demo] | Fix RM-XYZ :-------------------:|:----------: ## 🧰 Changes unskipping and fixing one of the html block tests ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
[![PR App][icn]][demo] | Fix RM-XYZ :-------------------:|:----------: ## 🧰 Changes who doesn't love a unit test ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
| [![PR App][icn]][demo] | RM-9815 | | :--------------------: | :-----: | ## 🧰 Changes Adds the heading ids to the tree when using `rmdx.hast`. These ids are used in the apps indexing job. ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
| 💬 [Thread] | | :---------: | - [x] optionally chain the TOC regex matcher [thread]: https://readmeio.slack.com/archives/C04R9PADCS3/p1720026196603799?thread_ts=1720025418.443289&cid=C04R9PADCS3
- [x] nix errant `console.log` per @jennspencer [on #933](#933 (comment))
## Version 6.75.0-beta.69 ### ✨ New & Improved * force release ([d3e4da3](d3e4da3)) ### 🛠 Fixes & Updates * **beta:** nix errant log ([#934](#934)) ([04b55eb](04b55eb)), closes [#933](#933) [/github.com//pull/933#discussion_r1664579308](https://github.com/readmeio//github.com/readmeio/markdown/pull/933/issues/discussion_r1664579308) <!--SKIP CI-->
[![PR App][icn]][demo] | Fix RM-10063 :-------------------:|:----------: ## 🧰 Changes Unhandled nodes are throwing errors during migration. Offending node types: - [x] `div` - [x] `embed` - [x] `figure` - [x] `i` - [x] `rdme-pin` - [x] `yaml` ## 🧬 QA & Testing You can look up the `Cannot handle unknown node <node>` errors from Aaron's [migration spreadsheet](https://docs.google.com/spreadsheets/d/1KVNWs8UeW_Gm7z2seR_ouTbHADXfZWLTUi87TBYB8ko/edit?gid=2109409773#gid=2109409773) to find pages to test locally, if you want to use `make mdx` to swap out the dist files in your `readme` repo. You'll have to check out [his other PR](https://github.com/readmeio/readme/pull/11999) with the migration scripts first, which has directions for testing pages. - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Describe your changes in detail.
🧬 QA & Testing