Merge pull request #6696 from readthedocs/humitos/sort-in-place

Sort vesions in-place to help performance
readthedocs · Mar 2, 2020 · d1fa693 · d1fa693
2 parents f11678a + a872379
commit d1fa693
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/readthedocs/projects/version_handling.py b/readthedocs/projects/version_handling.py
@@ -109,13 +109,12 @@ def sort_versions(version_list):
         if comparable_version:
             versions.append((version_obj, comparable_version))
 
-    return list(
-        sorted(
-            versions,
-            key=lambda version_info: version_info[1],
-            reverse=True,
-        ),
+    # sort in-place to avoid leaking memory on projects with lot of versions
+    versions.sort(
+        key=lambda version_info: version_info[1],
+        reverse=True,
     )
+    return versions
 
 
 def highest_version(version_list):