Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort vesions in-place to help performance #6696

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Sort vesions in-place to help performance #6696

merged 1 commit into from
Mar 2, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 24, 2020

Small improvement to help with projects with lot of versions.

@humitos humitos requested a review from a team February 24, 2020 16:39
davidfischer
davidfischer approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@davidfischer davidfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems fine but I doubt it'll change performance much either way.

@humitos humitos merged commit d1fa693 into master Mar 2, 2020
@humitos humitos deleted the humitos/sort-in-place branch March 2, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfischer davidfischer davidfischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @davidfischer