Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort vesions in-place to help performance #6696

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Sort vesions in-place to help performance #6696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions readthedocs/projects/version_handling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,12 @@ def sort_versions(version_list):
if comparable_version:
versions.append((version_obj, comparable_version))

return list(
sorted(
versions,
key=lambda version_info: version_info[1],
reverse=True,
),
# sort in-place to avoid leaking memory on projects with lot of versions
versions.sort(
key=lambda version_info: version_info[1],
reverse=True,
)
return versions


def highest_version(version_list):
Expand Down