Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support query args in redirects #2595

Closed
agjohnson opened this issue Jan 17, 2017 · 2 comments
Closed

Support query args in redirects #2595

agjohnson opened this issue Jan 17, 2017 · 2 comments
Labels
Bug A bug Good First Issue Good for new contributors

Comments

@agjohnson
Copy link
Contributor

A redirect should be able to pass on query args. Currently, a redirect hit with query args 404s.

@agjohnson agjohnson added Bug A bug Good First Issue Good for new contributors labels Jan 17, 2017
@humitos
Copy link
Member

humitos commented Feb 22, 2017

@agjohnson can you provide an example when you are receiving 404?

I just checked this URL: http://tox.readthedocs.io/?say=hello&di=hola and I was redirected to http://tox.readthedocs.io/en/latest/

On the other hand, in my example, would you like to be redirected to http://tox.readthedocs.io/en/latest/?say=hello&di=hola ?

andrew added a commit to andrew/readthedocs.org that referenced this issue Jul 13, 2017
andrew added a commit to andrew/readthedocs.org that referenced this issue Jul 13, 2017
@humitos
Copy link
Member

humitos commented Dec 6, 2017

Closing because it's done in the private repository. Thanks!

@humitos humitos closed this as completed Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug Good First Issue Good for new contributors
Projects
None yet
Development

No branches or pull requests

2 participants