Pass query string when redirecting, fixes #2595 #3001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! I'll get it tested locally and then merged in :) |
|
This file should also be removed, as should probably most anything under |
agjohnson
added
the
PR: work in progress
Do we still need this fix in the private repo version or it was already fixed? |
|
Nope. Still needs to be fixed :( |
|
OK, I copied the patch to that private repository you pointed me. Closing this PR, there is nothing else to do here. Thanks for your contribution! |
|
My first ever python contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a stab at fixing #2595, not worked with flask before but this seems to do the trick.