Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stable version even when it's inactive #5127

Closed
stsewd opened this issue Jan 18, 2019 · 1 comment
Closed

Update stable version even when it's inactive #5127

stsewd opened this issue Jan 18, 2019 · 1 comment
Labels
Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented Jan 18, 2019

When stable is inactive, we don't update it when new versions are created

https://github.com/rtfd/readthedocs.org/blob/3d5ad1ccda5b25ae574e14bedbbf0098c35a6d80/readthedocs/projects/models.py#L714-L714

This leads to stable have an old commit/identifier.

When stable is activated, we trigger a build but with an old commit, then stable is refreshed and a new build is triggered to stable.

This gives two builds to stable, one to an old commit and one to the real stable.

Any reason why we have this? We even have a test for this https://github.com/rtfd/readthedocs.org/blob/3d5ad1ccda5b25ae574e14bedbbf0098c35a6d80/readthedocs/rtd_tests/tests/test_sync_versions.py#L946

The only "downside" I can see is this, but not sure what would happen. I'll try to see this locally

https://github.com/rtfd/readthedocs.org/blob/3d5ad1ccda5b25ae574e14bedbbf0098c35a6d80/readthedocs/builds/models.py#L209-L210

@stsewd stsewd added the Needed: design decision A core team decision is required label Jan 18, 2019
@humitos
Copy link
Member

humitos commented Jan 23, 2019

If "update stable even when inactive" means to update the identifier, I think we should do it since it doesn't affect anything and will make it be consistent with the real stable once activated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

2 participants