Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always update the commit of the stable version #5421

Merged
merged 3 commits into from
Mar 18, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Mar 7, 2019

Fixes #5127

Verified

This commit was signed with the committer’s verified signature.
not-an-aardvark Teddy Katz
@stsewd stsewd added the PR: work in progress Pull request is not ready for full review label Mar 7, 2019
version_stable = Version.objects.get(slug=STABLE)
self.assertFalse(version_stable.active)
self.assertEqual(version_stable.identifier, '0.9')
self.assertEqual(version_stable.identifier, '1.0.0')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly the name of the tests is still valid :)

@stsewd stsewd removed the PR: work in progress Pull request is not ready for full review label Mar 7, 2019
@stsewd stsewd requested a review from a team March 7, 2019 22:49
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@stsewd stsewd merged commit 494afdf into readthedocs:master Mar 18, 2019
@stsewd stsewd deleted the always-update-stable branch March 18, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants