Conda Support: Relax strict dependency on sphinx 1.3.5 #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainCorlay
changed the title
|
This is breaking the build of several packages I work on. Is there a chance to get this in quickly? |
|
Thanks for the suggestion, but I'm going to reject this as a fix. We don't want to support arbitrary versions of sphinx out of the box, but this change would. We instead need to upgrade to a later version of sphinx, something no one has had time to test in any depth. If you'd like to take this on, we need some help QA'ing |
|
Would you allow a logic where the user can forcibly set a version of sphinx in environment.yml |
This was referenced May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2566 where the strict dependency on sphinx 1.3.5 in the core requirements prevents the use of tools that require a more recent version of sphinx.