Removed pinned versions from conda environments #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'commonmark==0.5.4', | ||
| 'recommonmark==0.1.1', | ||
| 'readthedocs-sphinx-ext', | ||
| 'recommonmark', |
There was a problem hiding this comment.
I do worry about unpinning these. @agjohnson would know best, but I believe there is a released version that might bork things.
This was referenced May 23, 2017
ericholscher
removed
the
PR: work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not pin required packages for Read The Docs but make sure they are installed once the environment is created using the
environment.ymlfrom the user's repository.I tried building
poliastroproject (https://github.com/poliastro/poliastro) in my local instance and it worked. This project used python 3.6 which was incompatible with our old setup.Related to #2566 #2584 #2589