Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start and termination to YAML file regex #4584

Merged
merged 3 commits into from
Aug 29, 2018
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 29, 2018

Otherwise it found files like:

.hg/store/data/readthedocs.yml.i

Closes #4583

@humitos
Copy link
Member Author

humitos commented Aug 29, 2018

It would be good to have a test for this :)

Otherwise it found files like:

  .hg/store/data/readthedocs.yml.i
@humitos humitos force-pushed the humitos/yaml/regex branch from 895f3ab to 18fd242 Compare August 29, 2018 21:10
@agjohnson agjohnson added Bug A bug PR: hotfix Pull request applied as hotfix to release Accepted Accepted issue on our roadmap labels Aug 29, 2018
@agjohnson
Copy link
Contributor

Added #4586 in case this is closed before

@stsewd
Copy link
Member

stsewd commented Aug 29, 2018

I'm pushing some tests right now

@stsewd
Copy link
Member

stsewd commented Aug 29, 2018

Tests in #4587

@agjohnson agjohnson removed the PR: hotfix Pull request applied as hotfix to release label Aug 29, 2018
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 👢

@agjohnson agjohnson merged commit dcb4270 into master Aug 29, 2018
@agjohnson agjohnson deleted the humitos/yaml/regex branch August 29, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants