Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for yaml file regex #4587

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Aug 29, 2018

It has #4584 as base, close #4586

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@agjohnson agjohnson merged commit 03b4a93 into readthedocs:humitos/yaml/regex Aug 29, 2018
agjohnson pushed a commit that referenced this pull request Aug 29, 2018
* Add start and termination to YAML file regex

Otherwise it found files like:

  .hg/store/data/readthedocs.yml.i

* Update common submodule

* Tests (#4587)
@stsewd stsewd deleted the tests-regex branch August 30, 2018 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants