Serve custom 404 pages from El Proxito and storage #6322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yea, I thought about doing something like this. It feels pretty janky, but is basically the same solution that I was thinking about, and I can't think of a better solution. |
|
OK! I'm closing this. I suppose that you will add these changes into #6286 and in the -ops repository. We can revisit this PR if needed. |
ericholscher
reviewed
Nov 7, 2019
|
|
||
| add_header X-Served Nginx-Proxito-Sendfile always; | ||
| } | ||
|
|
||
| # Serve 404 pages here | ||
| location @notfoundfallback { | ||
| proxy_pass http://proxito:8000/404$request_uri; |
There was a problem hiding this comment.
proxy_pass http://proxito:8000/_proxito_404_$request_uri;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #6306