Port additional features to proxito #6286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
changed the title
humitos
reviewed
Oct 18, 2019
Co-Authored-By: Manuel Kaufmann <humitos@gmail.com>
…org into proxito-cleanup
humitos
reviewed
Nov 7, 2019
Comment on lines
+220
to
+222
| self.assertEqual( | ||
| response.status_code, 404 | ||
| ) |
There was a problem hiding this comment.
We may want to assert that we are receiving the content of the custom page here as well and not the default maze.
robots.txt, sitemap.xml and custom 404 (on latest, on specific version and not on latest) work properly with the NGINX fallback. |
Co-Authored-By: Manuel Kaufmann <humitos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves over almost all of the doc serving logic from Django into Proxito. Most importantly:
It also fixes some of the bugs that we saw during the initial deployment:
/en/latest/foowhere it should servefoo/index.htmlThis required additional nginx configuration changes, which I will put in another PR in ops. It would be cool to be able to test them against this, but not quite there yet.
Closes #6331
Closes #6332