Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove workaround/compatibility for old 0.3 version #1106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Blendify
Copy link
Member

This should now be safe to remove. I tested locally and sticky nav work both on and off.

I am not sure about the rtd side if this cases issues.

This should now be safe to remove. I tested locally and sticky nav work both on and off.

I am not sure about the rtd side if this cases issues.
@Blendify Blendify added this to the 1.0 milestone Mar 30, 2021
@Blendify Blendify requested review from agjohnson, stsewd and a team March 30, 2021 17:09
@agjohnson agjohnson modified the milestones: 1.0, 1.1 Mar 31, 2021
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is okay, but I also feel like I'm overlooking something.

Background on this is that we used to host a common theme.css and theme.js for all projects to share. That file needed to be backwards compatible between HTML output from multiple theme versions because of that. Projects should have individual assets now, but it is also functionality that we have not yet fully deprecated that I know of.

@agjohnson
Copy link
Collaborator

Changes seem okay technically speaking, but it might be worth double checking on RTD usage first. In theory, old projects might use the common assets still, but we haven't updated the assets in the rtd.org repo in a while. Any changes here wouldn't be reflected in the common assets unless we decided to copy the built assets into rtd.org vendored assets again.

@davidfischer you helped split up common hosted assets back into per-build assets if I recall. Does this change seem relatively safe to you?

I did bump this out to 1.1 or later. I'd like to work towards a 1.0rc1 this week or next, and would like to limit the number of changes we're putting into that release.

@benjaoming benjaoming modified the milestones: 1.1, 2.0 Aug 26, 2022
@benjaoming
Copy link
Contributor

Marking this for 2.0 unless someone does a quick intervention :)

@humitos humitos mentioned this pull request Jul 24, 2024
@humitos humitos requested a review from a team as a code owner August 1, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants