Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Remove workaround/compatibility for old 0.3 version #1106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cleanup: Remove workaround/compatibility for old 0.3 version #1106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f617fd
Cleanup: Remove workaround/compatibility for old 0.3 version
Blendify Mar 30, 2021
0943f5e
Merge branch 'master' into Blendify/js-cleanup-rtd-workaround
humitos Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions src/theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@ function ThemeNav () {
nav.enable = function (withStickyNav) {
var self = this;

// TODO this can likely be removed once the theme javascript is broken
// out from the RTD assets. This just ensures old projects that are
// calling `enable()` get the sticky menu on by default. All other cals
// to `enable` should include an argument for enabling the sticky menu.
if (typeof(withStickyNav) == 'undefined') {
withStickyNav = true;
}

if (self.isRunning) {
// Only allow enabling nav logic once
return;
Expand Down Expand Up @@ -64,12 +56,6 @@ function ThemeNav () {

};

// TODO remove this with a split in theme and Read the Docs JS logic as
// well, it's only here to support 0.3.0 installs of our theme.
nav.enableSticky = function() {
this.enable(true);
};

nav.init = function ($) {
var doc = $(document),
self = this;
Expand Down Expand Up @@ -228,10 +214,6 @@ module.exports.ThemeNav = ThemeNav();
if (typeof(window) != 'undefined') {
window.SphinxRtdTheme = {
Navigation: module.exports.ThemeNav,
// TODO remove this once static assets are split up between the theme
// and Read the Docs. For now, this patches 0.3.0 to be backwards
// compatible with a pre-0.3.0 layout.html
StickyNav: module.exports.ThemeNav,
};
}

Expand Down