Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify regex #3145

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Simplify regex #3145

merged 2 commits into from
Mar 18, 2020

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Mar 18, 2020

\w already includes _

`\w` already includes `_`
@SwiftLintBot
Copy link

SwiftLintBot commented Mar 18, 2020

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
12 Messages
📖 Linting Aerial with this PR took 1.3s vs 1.27s on master (2% slower)
📖 Linting Alamofire with this PR took 2.16s vs 2.15s on master (0% slower)
📖 Linting Firefox with this PR took 9.05s vs 8.93s on master (1% slower)
📖 Linting Kickstarter with this PR took 14.05s vs 14.05s on master (0% slower)
📖 Linting Moya with this PR took 1.31s vs 1.31s on master (0% slower)
📖 Linting Nimble with this PR took 1.37s vs 1.33s on master (3% slower)
📖 Linting Quick with this PR took 0.53s vs 0.53s on master (0% slower)
📖 Linting Realm with this PR took 2.32s vs 2.33s on master (0% faster)
📖 Linting SourceKitten with this PR took 0.99s vs 1.01s on master (1% faster)
📖 Linting Sourcery with this PR took 6.69s vs 6.69s on master (0% slower)
📖 Linting Swift with this PR took 12.35s vs 12.4s on master (0% faster)
📖 Linting WordPress with this PR took 15.07s vs 15.18s on master (0% faster)

Here's an example of your CHANGELOG entry:

* Simplify regex.  
  [jpsim](https://github.com/jpsim)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@jpsim
Copy link
Collaborator Author

jpsim commented Mar 18, 2020

Thanks @kastiglione

@jpsim
Copy link
Collaborator Author

jpsim commented Mar 18, 2020

/merge

@jpsim jpsim merged commit c201ae4 into master Mar 18, 2020
@jpsim jpsim deleted the simplify-regex branch March 18, 2020 23:23
pull bot pushed a commit to scope-demo/SwiftLint that referenced this pull request Mar 18, 2020
* Simplify regex

`\w` already includes `_`

* Fix test
optionalendeavors added a commit to optionalendeavors/SwiftLint that referenced this pull request Jul 12, 2020
* master: (101 commits)
  JUnit reporter for GitLab artifact:report:junit (realm#3177)
  Add empty changelog section
  release 0.39.2
  Update CI to run jobs with Xcode 11.0 to 11.4 (realm#3168)
  Fix false positives in valid_ibinspectable rule when using Swift 5.2 (realm#3155)
  Fix attributes rule false positive with Swift 5.2 (realm#3154)
  Fix CHANGELOG link
  Fix false positives in redundant_objc_attribute with Swift 5.2 (realm#3152)
  Fix false positives on implicit_getter with Swift 5.2+ (realm#3151)
  Simplify regex (realm#3145)
  fix links about configuration rules (realm#3142)
  Add unused_import config options to require imports for each module used (realm#3123)
  Add empty changelog section
  release 0.39.1
  Temporarily remove all SwiftSyntax rules and support (realm#3107)
  Fix unused_import rule reported locations and corrections (realm#3106)
  release 0.39.0
  Fix false positive in `empty_string` rule with multiline literals (realm#3101)
  Fix PrivateActionRule in Swift 5.2 (realm#3092)
  Fix false positive in implicit_getter with Swift 5.2 (realm#3099)
  ...

# Conflicts:
#	Source/SwiftLintFramework/Extensions/SwiftLintFile+Regex.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants