Temporarily remove all SwiftSyntax rules and support #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to revert all this stuff @marcelofabri. At least all this stuff is fairly self-contained and shouldn't lead to too many merge conflicts when we sort out the packaging details. |
optionalendeavors
added a commit
to optionalendeavors/SwiftLint
that referenced
this pull request
Jul 12, 2020
* master: (101 commits) JUnit reporter for GitLab artifact:report:junit (realm#3177) Add empty changelog section release 0.39.2 Update CI to run jobs with Xcode 11.0 to 11.4 (realm#3168) Fix false positives in valid_ibinspectable rule when using Swift 5.2 (realm#3155) Fix attributes rule false positive with Swift 5.2 (realm#3154) Fix CHANGELOG link Fix false positives in redundant_objc_attribute with Swift 5.2 (realm#3152) Fix false positives on implicit_getter with Swift 5.2+ (realm#3151) Simplify regex (realm#3145) fix links about configuration rules (realm#3142) Add unused_import config options to require imports for each module used (realm#3123) Add empty changelog section release 0.39.1 Temporarily remove all SwiftSyntax rules and support (realm#3107) Fix unused_import rule reported locations and corrections (realm#3106) release 0.39.0 Fix false positive in `empty_string` rule with multiline literals (realm#3101) Fix PrivateActionRule in Swift 5.2 (realm#3092) Fix false positive in implicit_getter with Swift 5.2 (realm#3099) ... # Conflicts: # Source/SwiftLintFramework/Extensions/SwiftLintFile+Regex.swift
|
Once someone comes up with a suitable distribution plan yes. |
jpsim
added a commit
that referenced
this pull request
Mar 7, 2022
We've tried adding Swift Syntax support to SwiftLint in the past but had to turn it off in #3107 due to distribution and portability issues. With https://github.com/keith/StaticInternalSwiftSyntaxParser it should be possible to avoid those issues by statically linking the internal Swift syntax parser so it's available no matter where users have Xcode installed on their computer. By removing all calls to SourceKit (collecting comment commands + checking the current Swift version), there's a really significant performance improvement. | Framework | Mean [ms] | Min [ms] | Max [ms] | Relative | |:---|---:|---:|---:|---:| | SourceKit | 517.8 ± 8.3 | 505.5 | 531.1 | 6.59 ± 0.43 | | SwiftSyntax | 78.6 ± 5.0 | 72.6 | 92.1 | 1.00 | In practice, the SourceKit overhead will continue being there for as long as any rule being run is still looking up the SwiftLint syntax map though.
jpsim
added a commit
that referenced
this pull request
Mar 9, 2022
We've tried adding Swift Syntax support to SwiftLint in the past but had to turn it off in #3107 due to distribution and portability issues. With https://github.com/keith/StaticInternalSwiftSyntaxParser it should be possible to avoid those issues by statically linking the internal Swift syntax parser so it's available no matter where users have Xcode installed on their computer. By removing all calls to SourceKit (collecting comment commands + checking the current Swift version), there's a really significant performance improvement. | Framework | Mean [ms] | Min [ms] | Max [ms] | Relative | |:---|---:|---:|---:|---:| | SourceKit | 517.8 ± 8.3 | 505.5 | 531.1 | 6.59 ± 0.43 | | SwiftSyntax | 78.6 ± 5.0 | 72.6 | 92.1 | 1.00 | In practice, the SourceKit overhead will continue being there for as long as any rule being run is still looking up the SwiftLint syntax map though.
coffmark
pushed a commit
to coffmark/SwiftLint
that referenced
this pull request
Apr 11, 2022
We've tried adding Swift Syntax support to SwiftLint in the past but had to turn it off in realm#3107 due to distribution and portability issues. With https://github.com/keith/StaticInternalSwiftSyntaxParser it should be possible to avoid those issues by statically linking the internal Swift syntax parser so it's available no matter where users have Xcode installed on their computer. By removing all calls to SourceKit (collecting comment commands + checking the current Swift version), there's a really significant performance improvement. | Framework | Mean [ms] | Min [ms] | Max [ms] | Relative | |:---|---:|---:|---:|---:| | SourceKit | 517.8 ± 8.3 | 505.5 | 531.1 | 6.59 ± 0.43 | | SwiftSyntax | 78.6 ± 5.0 | 72.6 | 92.1 | 1.00 | In practice, the SourceKit overhead will continue being there for as long as any rule being run is still looking up the SwiftLint syntax map though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new rules introduced in 0.39.0 that depend on SwiftSyntax have been temporarily removed as we work out release packaging issues.
prohibited_nan_comparisonreturn_value_from_void_functiontuple_patternvoid_function_in_ternarySee #3105 for details.