Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated inert_defer rule entirely #5894

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

SimplyDanny
Copy link
Collaborator

The rule has been deprecated for 2 years.

@SimplyDanny SimplyDanny force-pushed the remove-deprecated-rule branch from 3ecb2fd to a938cca Compare December 9, 2024 23:09
@SwiftLintBot
Copy link

SwiftLintBot commented Dec 9, 2024

19 Messages
📖 Linting Aerial with this PR took 0.92s vs 0.95s on main (3% faster)
📖 Linting Alamofire with this PR took 1.27s vs 1.41s on main (9% faster)
📖 Linting Brave with this PR took 7.18s vs 7.22s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 5.29s vs 5.33s on main (0% faster)
📖 Linting Firefox with this PR took 10.81s vs 10.81s on main (0% slower)
📖 Linting Kickstarter with this PR took 10.1s vs 10.16s on main (0% faster)
📖 Linting Moya with this PR took 0.53s vs 0.53s on main (0% slower)
📖 Linting NetNewsWire with this PR took 2.9s vs 2.91s on main (0% faster)
📖 Linting Nimble with this PR took 0.77s vs 0.78s on main (1% faster)
📖 Linting PocketCasts with this PR took 8.69s vs 8.6s on main (1% slower)
📖 Linting Quick with this PR took 0.47s vs 0.44s on main (6% slower)
📖 Linting Realm with this PR took 4.51s vs 4.48s on main (0% slower)
📖 Linting Sourcery with this PR took 2.31s vs 2.31s on main (0% slower)
📖 Linting Swift with this PR took 4.52s vs 4.51s on main (0% slower)
📖 Linting VLC with this PR took 1.25s vs 1.25s on main (0% slower)
📖 Linting Wire with this PR took 18.06s vs 17.99s on main (0% slower)
📖 Linting WordPress with this PR took 11.39s vs 11.4s on main (0% faster)
📖 This PR fixed a violation in Sourcery: /SourceryRuntime/Sources/Common/FileParserResult.swift:52:9: warning: Inert Defer Violation: If defer is at the end of its parent scope, it will be executed right where it is anyway (inert_defer)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Blog/Site Management/TableViewHeaderDetailView.swift:74:9: warning: Inert Defer Violation: If defer is at the end of its parent scope, it will be executed right where it is anyway (inert_defer)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny enabled auto-merge (squash) December 9, 2024 23:09
@SimplyDanny SimplyDanny merged commit f2175c1 into main Dec 9, 2024
14 checks passed
@SimplyDanny SimplyDanny deleted the remove-deprecated-rule branch December 9, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants