Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated inert_defer rule entirely #5894

Merged
merged 1 commit into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
[Bradley Mackey](https://github.com/bradleymackey)
[#5514](https://github.com/realm/SwiftLint/issues/5514)

* The `inert_defer` and `unused_capture_list` rules have completely been removed after being deprecated for 2 years.
[SimplyDanny](https://github.com/SimplyDanny)

#### Experimental

* None.
Expand Down
1 change: 0 additions & 1 deletion Source/SwiftLintBuiltInRules/Models/BuiltInRules.swift
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ public let builtInRules: [any Rule.Type] = [
ImplicitlyUnwrappedOptionalRule.self,
InclusiveLanguageRule.self,
IndentationWidthRule.self,
InertDeferRule.self,
InvalidSwiftLintCommandRule.self,
IsDisjointRule.self,
JoinedDefaultParameterRule.self,
Expand Down
116 changes: 0 additions & 116 deletions Source/SwiftLintBuiltInRules/Rules/Lint/InertDeferRule.swift

This file was deleted.

6 changes: 0 additions & 6 deletions Tests/GeneratedTests/GeneratedTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -541,12 +541,6 @@ final class IndentationWidthRuleGeneratedTests: SwiftLintTestCase {
}
}

final class InertDeferRuleGeneratedTests: SwiftLintTestCase {
func testWithDefaultConfiguration() {
verifyRule(InertDeferRule.description)
}
}

final class InvalidSwiftLintCommandRuleGeneratedTests: SwiftLintTestCase {
func testWithDefaultConfiguration() {
verifyRule(InvalidSwiftLintCommandRule.description)
Expand Down
2 changes: 0 additions & 2 deletions Tests/IntegrationTests/default_rule_configurations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,6 @@ indentation_width:
include_comments: true
include_compiler_directives: true
include_multiline_strings: true
inert_defer:
severity: warning
invalid_swiftlint_command:
severity: warning
is_disjoint:
Expand Down