Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use right allocator when performing queries over links #4417

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Feb 11, 2021

What, How & Why?

This is an alternative to #4415

tgoyne and others added 2 commits February 10, 2021 13:58
This is an attempt at a more general solution to the same problem as f045da0.
There are several places where queries are using the allocator from one Table
while accessing another Table. Rather than attempting to validate that all of
them are correct, instead update each Table's WrappedAllocator before running
the query so that it doesn't matter which one is used.
Copy link
Contributor

@finnschiermer finnschiermer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazeballs!

@jedelbo jedelbo merged commit 5e92537 into master Feb 12, 2021
@jedelbo jedelbo deleted the je/query-alloc-assert branch February 12, 2021 09:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants