Revisit metrics test - update metrics to store whether or not sync to disk was disabled #6206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ironage
reviewed
Jan 18, 2023
There was a problem hiding this comment.
Interesting that this is still failing. I'm not sure this solution explains the failures? This is a NONCONCURRENT_TEST so there shouldn't be any async tests running which turn on or off the disable_sync_to_disk flag. I would prefer to just use NONCONCURRENT_TEST_IF(..., false) (with an explanatory comment) to disable this entire test for now since these metrics aren't actually used for anything in production right now.
michael-wb
force-pushed
the
mwb/update-metrics-test2
branch
from
ed5a0b5
to
10d0a9e
Compare
danieltabacaru
approved these changes
Feb 7, 2023
ironage
approved these changes
Feb 7, 2023
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Revisit the
Metrics_TransactionTimingstest since failures were still being observed as a result of the test.For now, just disable the failing line and investigate why the final
get_fsync_time_nanoseconds()check in the test is sometimes returning0. Since this is a "non-concurrent" test, there shouldn't be any other tests that are running that could change the disable_sync_to_disk setting.☑️ ToDos
[ ] C-API, if public C++ API changed.