Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master, adapt exceptions #6361

Merged

Conversation

kiburtse
Copy link
Contributor

@kiburtse kiburtse commented Mar 3, 2023

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

jedelbo and others added 30 commits April 26, 2022 13:44
Introduce Exception class
* Merge former LogicError exception into the new scheme
* Unify error codes between C++ and C API
* Merge util::File::AccessError into unified scheme
AppError is no longer based on std::error code, which means that the various places where
we beforehand used std::error_code as a parameter (notably callbacks) had to change.
We now use Status as the standard way of passing status around (which seems logical).
However, it is nol only AppError information we pass around, but also information from
SyncError. SyncError is heavily based on std::error_code and it would be a rather big
task to step away from that. So in order to be able to also pass std::error_code around
in a Status object, Status class is enhanced to also to contain that information. This
allows us to make SyncError inherit from SystemError with the information stored in the
underlying Status object.
…nification

* origin/master:
  Stop forcing enums to be 64 bits unnecessarily
  clean up documentation of internal fields in config structs
  SyncConfig should be default constructible
  Traversal functions use IteratorControl values rather than true/false which is more expressive (#5857)
  Fix handling of 4-byte UTF8 values on Windows (#5803)
  Encode links in a way the server can understand (#5835)
  expose `Group::remove_table` in the C API (#5860)
  Disable auto refresh for old realm during migration (#5856)
  Expose `list_find` in the c api (#5848)
  Do not allow asymmetric tables in pbs (#5853)
  Refactor link tracing code (#5796)
  Expose `Obj::get_parent_object` in the C API (#5851)
  Update app.hpp (#5854)
  Fix appending to list ignores existing query (#5850)
…nification

* origin/master:
  Improve type check when casting to WrapC
  Updated release notes
  Throw exception if flx sync during realm conversation (fix flacky test) (#5869)
  Update install-baas to use go 1.18.6 (#5863)
  throw inside realm convert if realm uses flx sync (#5846)
  Update release notes
  Prepare release
  Store an optional Query on TableView
  Replace the typed aggregate functions with simpler untyped ones
  Add basic benchmarks for aggregate operations
  Add non-installed headers to the CMake project
  Remove a double-lookup when reading Dictionary values by index
…nification

* origin/master:
  Fix a data race in notifier packaging (#5892)
  Install util/http.hpp (#5893)
  Greatly improve performance of sorting dictionaries (#5168)
  Sync client shall not block user writes (#5844)
  update err message check (#5884)
jedelbo and others added 22 commits February 23, 2023 11:58
* Added mock error - always return 0 on error for secure transport

* Fixed non MacOS compile error - clang-format

* Updated changelog, clang-format

* Allow non-zero length for end-of-input

* Fix ConnectFailure during app: app destroyed during token refresh test

* Fix sync_test lockup

* Updates from review

* Fix ssl nonzero error tests

* Fixed ssl nonzero error tests and fast completing read/write operations

* Updated changelog and update from review

* Removed io_reactor interrupt and updated new tests to post operations on the event loop
* Make the network code compile

* Move WebSocketError definition to websocket.hpp

* WebSocket errors refactoring

* Introduce coarse-grained websocket errors to ErrorCodes::Error

* Replace RLM_SYNC_ERROR_CATEGORY_RESOLVE with RLM_SYNC_ERROR_CATEGORY_WEBSOCKET for sync errors in C API

* Fix object-store tests

* Fix wrong merge in sync_session.cpp

Co-authored-by: Daniel Tabacaru <daniel.tabacaru9@gmail.com>
* Added test and updated binding callback c_api - updated commented out sync test

* REQUIRE() not REALM_ASSERT()

* Update/Fix changelog

* clang format

* Allow nullptr userdata

* Revert changelog

* Reworked event loop in test to fix TSAN failure

* Reworked binding callback thread observer to fix TSAN issues

* Include mutex header file

* Updated changelog and renamed func name

* Updates from review

* Updated test to remove operator==

* Fix compile

* Removed global binding callback thread observer

* sync tests are no longer hanging

* Reverted sync client changes and disabled MultipleSyncAgents test

* Removed service.reset()

* Updated changelog after merging release

* Cleaned up binding callback observer interface and c_api

* Additional thread observer cleanup

* removed unused header files

* Found one more unused header file
* Initial design of MigrationStore

* Changes after initial code review

* Fix Package.swift

* Add NotStarted migration state

* Changes after code review

* Simplify MigrationState

* Small fixes

* changelog
* Extend filesystem unicode path test

* make test fail

* fix

* remove ONLY

* Fix File::resolve

* fix test

* fix make_temp_dir

* changelog
This was used by ROS to decide when to vacuum Realms and was planned to be used
to only bill users for actual data size rather than the size of the Realm files
on disk, but that appears not to have shipped. It is no longer used by
anything.
@kiburtse kiburtse merged commit d949d83 into feature/geospatial_queries_for_points Mar 13, 2023
@kiburtse kiburtse deleted the kb/geospatial_merge_master branch March 13, 2023 09:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.