Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BadChangesetError and TransformError notify users to contact support #6283

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

danieltabacaru
Copy link
Collaborator

@danieltabacaru danieltabacaru commented Feb 7, 2023

What, How & Why?

There are errors/exceptions which require help from support. Therefore, such error messages will mention Please contact support.

By default, all BadChangesetError's will contain the message above.
Additionally, TransformError's not related to schema will contain the message above.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@danieltabacaru danieltabacaru marked this pull request as ready for review February 7, 2023 12:19
@danieltabacaru danieltabacaru requested review from jedelbo, jbreams and ianpward and removed request for jedelbo February 7, 2023 12:20
Copy link
Contributor

@jbreams jbreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@danieltabacaru danieltabacaru merged commit 0ed74b2 into master Feb 7, 2023
@danieltabacaru danieltabacaru deleted the dt/notify_users_to_contact_support branch February 7, 2023 14:11
@kiburtse kiburtse mentioned this pull request Mar 3, 2023
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants