Fix crash caused by null embedded objects when converting local realm to sync'd realm #6295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicola-cab
approved these changes
Feb 10, 2023
| @@ -52,6 +52,9 @@ void generate_properties_for_obj(Replication& repl, const Obj& obj, const ColInf | |||
| auto embedded_table = elem.second; | |||
| auto cols_2 = get_col_info(embedded_table); | |||
| auto update_embedded = [&](Mixed val) { | |||
| if (val.is_null()) { | |||
There was a problem hiding this comment.
so it seems we never really cater for this use case, we have always taken for granted the fact that the link could have never been NULL, I think this is the result of how we are masking invalid links. So I think this fix is correct.
test/object-store/realm.cpp
Outdated
| @@ -1282,7 +1288,12 @@ TEST_CASE("SharedRealm: convert") { | |||
| SECTION("can copy a synced realm to a synced realm") { | |||
| auto sync_realm1 = Realm::get_shared_realm(sync_config1); | |||
| sync_realm1->begin_transaction(); | |||
| // 'embedded_link' property is null. | |||
There was a problem hiding this comment.
I would have added a separate test for covering this with a separate schema, but that's ok.
|
LGTM |
danieltabacaru
deleted the
dt/convert_fails_for_null_embedded_objects
branch
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Fix crash when converting local realm to sync'd realm if an embedded object is null.
Fixes #6294, realm-js#5389
☑️ ToDos
C-API, if public C++ API changed.