realm · kiburtse · Mar 13, 2023 · Apr 26, 2022 · Apr 27, 2022 · Apr 28, 2022
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,12 +2,61 @@
 
 ### Enhancements
 * <New feature description> (PR [#????](https://github.com/realm/realm-core/pull/????))
+* Add per app support for BindingCallbackThreadObserver ([#6250](https://github.com/realm/realm-core/issues/6250))
+
+### Fixed
+* Fixed handling of non-ASCII characters in file paths. ([#6336](https://github.com/realm/realm-core/issues/6336), since v13.4.0)
+
+### Breaking changes
+* BindingCallbackThreadObserver interface was updated to be part of SyncClientConfig and global instance was removed. ([PR #6156](https://github.com/realm/realm-core/pull/6156))
+
+### Compatibility
+* Fileformat: Generates files with format v23. Reads and automatically upgrade from fileformat v5.
+
+-----------
+
+### Internals
+* Add CAPI test for Binding Callback Thread Observer. ([PR #6156](https://github.com/realm/realm-core/pull/6156))
+* Implement MigrationStore to support migration from PBS to FLX ([PR #6324](https://github.com/realm/realm-core/pull/6324))
+
+----------------------------------------------
+
+# 13.5.0 Release notes
+
+### Enhancements
 * None.
 
 ### Fixed
-* <How do the end-user experience this issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?)
+* Converting local realm to sync'd realm crashes if an embedded object is null ([#6294](https://github.com/realm/realm-core/issues/6294), since v11.9.0)
+* Fixed performance degradation on SubQueries ([#6327](https://github.com/realm/realm-core/issues/6327), since v6.0.0)
+* The C API type `realm_sync_error_code_t` did not include a textural representation of the underlying category. ([#5399](https://github.com/realm/realm-core/issues/5399)),
+* Fixed several cases where wrong type of exception was thrown ([#6208](https://github.com/realm/realm-core/issues/6208), never released)
+* Fixed classification of InvalidQuery exception ([#6223](https://github.com/realm/realm-core/issues/6223), never released)
+* Fix crash if secure transport returns an error with a non-zero length. ([#5435](https://github.com/realm/realm-core/issues/5435), since 10.0.0)
+
+### Breaking changes
+* All exceptions thrown out of Core are now of type 'Exception'. All use of std::runtime_error and std::logical_error etc. has stopped and the specialized error classes that beforehand were based on these are now based on Exception.
+
+### Compatibility
+* Fileformat: Generates files with format v23. Reads and automatically upgrade from fileformat v5.
+
+-----------
+
+### Internals
+* Fixed a test failure originating due to the location for flexible sync permissions in the new version of baas changing.
+([#6319](https://github.com/realm/realm-core/pull/6319))
+
+----------------------------------------------
+
+# 13.4.2 Release notes
+
+### Enhancements
 * None.
 
+### Fixed
+* Sync client may [have failed an assertion](https://github.com/realm/realm-core/blob/006660c8d20c4941d3838f74aec6f3561ebf6784/src/realm/sync/noinst/client_impl_base.cpp#L388) during shutdown if all sessions hadn't been ready to finalize by the time the Client destructor ran. (PR [#6293](https://github.com/realm/realm-core/pull/6293), since v13.4.1)
+* Fixed the sync client being stuck in a cycle if an integration error occurs by issuing a client reset ([#6051](https://github.com/realm/realm-core/issues/6051), since v10.2.0)
+
 ### Breaking changes
 * None.
 
@@ -16,8 +65,65 @@
 
 -----------
 
+### Internals
+* Upgrade OpenSSL from 3.0.7 to 3.0.8. ([#6305](https://github.com/realm/realm-core/pull/6305))
+* Windows improvements in util/file ([PR #6221](https://github.com/realm/realm-core/pull/6221)):
+ * The following APIs are now implemented using std::filesystem: `try_make_dir`/`make_dir`, `make_dir_recursive`, `try_remove_dir`/`remove_dir`, `try_remove_dir_recursive`/`remove_dir_recursive`, `File::exists`, `File::is_dir`, `File::try_remove`/`File::remove`, `File::move`, `File::copy`, `File::last_write_time`, `File::get_free_space`
+ * `File::get_unique_id` now works on Windows
+ * Replaced manual path string conversion with `std::filesystem::path`
+* Update yarn download path in install_baas.sh ([PR #6309](https://github.com/realm/realm-core/pull/6309))
+* Include the websocket close status reason when reporting errors to the sync client ([PR #6298](https://github.com/realm/realm-core/pull/6298))
+
+----------------------------------------------
+
+# 13.4.1 Release notes
+
+### Enhancements
+* IntegrationException's which require help from support team mention 'Please contact support' in their message ([#6283](https://github.com/realm/realm-core/pull/6283))
+* Add support for nested and overlapping scopes to the Events API. If multiple scopes are active all events generated will be reported to every active scope ([#6288](https://github.com/realm/realm-core/pull/6288)).
+
+### Fixed
+* App 301/308 redirection support doesn't use new location if metadata mode is set to 'NoMetadata'. ([#6280](https://github.com/realm/realm-core/issues/6280), since v12.9.0)
+* Expose ad hoc interface for querying dictionary key changes in the C-API. ([#6228](https://github.com/realm/realm-core/issues/6228), since v10.3.3)
+* Client reset with recovery or discard local could fail if there were dangling links in lists that got ressurected while the list was being transferred from the fresh realm ([#6292](https://github.com/realm/realm-core/issues/6292), since v11.5.0)
+
+### Breaking changes
+* None.
+
+### Compatibility
+* Fileformat: Generates files with format v23. Reads and automatically upgrade from fileformat v5.
+
+-----------
+
+### Internals
+* The lifecycle of the sync client is now separated from the event loop/socket provider it uses for async I/O/timers. The sync client will wait for all outstanding callbacks/sockets to be closed during destruction. The SyncSocketProvider passed to the sync client must run until after the sync client is destroyed but does not need to be stopped as part of tearing down the sync client. ([PR #6276](https://github.com/realm/realm-core/pull/6276))
+* The default event loop will now keep running until it is explicitly stopped rather than until there are no more timers/IO to process. Previously there was a timer set for very far in the future to force the event loop to keep running. ([PR #6265](https://github.com/realm/realm-core/pull/6265))
+* Disable failing check in Metrics_TransactionTimings test ([PR #6206](https://github.com/realm/realm-core/pull/6206))
+* Map ClientError's to ProtocolError's and use ProtocolError's when sending ERROR messages to the server ([PR #6086](https://github.com/realm/realm-core/pull/6086))
+
+----------------------------------------------
+
+# 13.4.0 Release notes
+
+### Enhancements
+* Improve performance of interprocess mutexes on iOS which don't need to support reader-writer locking. The primary beneficiary of this is beginning and ending read transactions, which is now almost as fast as pre-v13.0.0 ([PR #6258](https://github.com/realm/realm-core/pull/6258)).
+
+### Fixed
+* Sharing Realm files between a Catalyst app and Realm Studio did not properly synchronize access to the Realm file ([PR #6258](https://github.com/realm/realm-core/pull/6258), since v6.21.0).
+* Fix websocket redirection after server migration if user is logged in ([#6056](https://github.com/realm/realm-core/issues/6056), since v12.9.0)
+* Freezing an immutable Realm would hit an assertion failure ([#6260]https://github.com/realm/realm-core/issues/6260), since v13.3.0).
+
+### Breaking changes
+* Remove Group::compute_aggregated_byte_size(), which is no longer used by anything.
+
+### Compatibility
+* Fileformat: Generates files with format v23. Reads and automatically upgrade from fileformat v5.
+
+-----------
+
 ### Internals
 * Added `REALM_ARCHITECTURE_ARM32` and `REALM_ARCHITECTURE_ARM64` macros to `features.h` for easier platform detection. ([#6256](https://github.com/realm/realm-core/pull/6256))
+* Create the fuzzer framework project in order to run fuzz testing on evergreen ([PR #5940](https://github.com/realm/realm-core/pull/5940))
 
 ----------------------------------------------
 
@@ -28,6 +134,7 @@
 * Improve the performance of `Realm::freeze()` by eliminating some redudant work around schema initialization and validation. These optimizations do not apply to Realm::get_frozen_realm() ([PR #6211](https://github.com/realm/realm-core/pull/6211)).
 * Include context about what object caused the merge exception in OT ([#6204](https://github.com/realm/realm-core/issues/6204))
 * Add support for `Dictionary::get_keys()`, `Dictionary::contains()`, `Dictionary::find_any()` in the C API. ([#6181](https://github.com/realm/realm-core/issues/6181))
+* Adds upport for in-memory Realms. If a Realm is opened without a path it will be in memory only.
 
 ### Fixed
 * "find first" on Decimal128 field with value NaN does not find objects ([6182](https://github.com/realm/realm-core/issues/6182), since v6.0.0)
@@ -41,6 +148,7 @@
 * Online compaction may cause a single commit to take a long time ([#6245](https://github.com/realm/realm-core/pull/6245), since v13.0.0)
 * Expose `collection_was_cleared` in the C API ([#6200](https://github.com/realm/realm-core/issues/6200), since v.10.4.0)
 * `Set<Mixed>::sort()` used a different sort order from sorting any other collection, including a filtered `Set<Mixed>` ([PR #6238](https://github.com/realm/realm-core/pull/6238), since v13.0.0).
+* Fix issue where calling `RealmCoordinator::get_realm(Realm::Config, util::Optional<VersionID>)` would not correctly set `m_schema_version` to `ObjectStore::NotVersioned` if no schema was provided in the config when the realm is first opened ([PR #6236](https://github.com/realm/realm-core/pull/6236), since v10.0.0).
 
 ### Breaking changes
 * `SyncSession::log_out()` has been renamed to `SyncSession::force_close()` to reflect what it actually does ([#6183](https://github.com/realm/realm-core/pull/6183))
@@ -85,11 +193,11 @@
 * Fixed possible segfault in sync client where async callback was using object after being deallocated ([#6053](https://github.com/realm/realm-core/issues/6053), since v11.7.0)
 * Fixed crash when using client reset with recovery and flexible sync with a single subscription ([#6070](https://github.com/realm/realm-core/issues/6070), since v12.3.0)
 * Fixed crash with wrong transaction state, during realm migration if realm is frozen due to schema mismatch ([#6144](https://github.com/realm/realm-core/issues/6144), since v13.0.0)
- 
+
 ### Breaking changes
 * Core no longer provides any vcpkg infrastructure (the ports submodule and overlay triplets), because it handles dependant libraries internally now.
 * Allow Realm instances to have a complete view of their schema, if mode is additive. ([PR #5784](https://github.com/realm/realm-core/pull/5784)).
-* `realm_sync_immediately_run_file_actions` (c-api) now takes a third argument `bool* did_run` that will be set to the result of `SyncManager::immediately_run_file_actions`. ((#6117)[https://github.com/realm/realm-core/pull/6117]) 
+* `realm_sync_immediately_run_file_actions` (c-api) now takes a third argument `bool* did_run` that will be set to the result of `SyncManager::immediately_run_file_actions`. ((#6117)[https://github.com/realm/realm-core/pull/6117])
 * Device information in sync connection parameters was moved into a new `device_info` structure in App::Config ([PR #6066](https://github.com/realm/realm-core/pull/6066))
 * `sdk` is now a required field in the `device_device` structure in App::Config ([PR #6066](https://github.com/realm/realm-core/pull/6066))
 
@@ -117,7 +225,7 @@
 ### Fixed
 * Fixed `realm_add_realm_refresh_callback` and notify immediately that there is not transaction snapshot to advance to. ([#6075](https://github.com/realm/realm-core/issues/6075), since v12.6.0)
 * Fix no notification for write transaction that contains only change to backlink property. ([#4994](https://github.com/realm/realm-core/issues/4994), since v11.4.1)
- 
+
 ### Breaking changes
 * FLX Subscription API reworked to better match SDK consumption patterns ([#6065](https://github.com/realm/realm-core/pull/6065)). Not all changes are breaking, but listing them all here together.
  * `Subscription` is now a plain struct with public fields rather than getter functions
@@ -143,7 +251,7 @@
 ### Fixed
 * Not possible to open an encrypted file on a device with a page size bigger than the one on which the file was produced. ([#8030](https://github.com/realm/realm-swift/issues/8030), since v12.11.0)
 * Fixed `realm_refresh` so it uses an argument value for the refresh result and returns any error conditions as return value. ([#6068](https://github.com/realm/realm-core/pull/6068), since v10.4.0)
-* Fixed `realm_compact` to actually do the compaction even if the caller did not provide a `did_compact` argument. ([#6068](https://github.com/realm/realm-core/pull/6068), since v12.7.0) 
+* Fixed `realm_compact` to actually do the compaction even if the caller did not provide a `did_compact` argument. ([#6068](https://github.com/realm/realm-core/pull/6068), since v12.7.0)
 ### Breaking changes
 * ObjectId constructor made explicit, so no more implicit conversions from const char* or array of 12 bytes. It now accepts a StringData. ([#6059](https://github.com/realm/realm-core/pull/6059))
 
@@ -210,7 +318,7 @@
 * Restore fallback to full barrier when F_BARRIERSYNC is not available on Apple platforms. ([PR #6033](https://github.com/realm/realm-core/pull/6033), since v12.12.0)
 * Validation of Queries constructed by the Fluent QueryBuilder was missing. ([#6034](https://github.com/realm/realm-core/issues/6034), since v12.7.0)
 * Allow setting values on a Mixed property through the C API ([#5985](https://github.com/realm/realm-core/issues/5985), since v10.5.0)
- 
+
 ### Breaking changes
 * `Table::query()` overload taking `vector<vector<Mixed>>` now takes `vector<variant<Mixed, vector<Mixed>>>` in order to distinguish scalar arguments from single-element lists. ([#5973](https://github.com/realm/realm-core/pull/5973))
 * Better error handling for `realm_async_begin_write` and `realm_async_commit`. ([#PR6039](https://github.com/realm/realm-core/pull/6039))
@@ -384,7 +492,7 @@
 * Fix crash when upserting a document with the primary key not an ObjectId into a mongo collection. ([#5345](https://github.com/realm/realm-core/issues/5345), since v10.0.0).
 
 ### Breaking changes
-None.
+* None.
 
 ### Compatibility
 * Fileformat: Generates files with format v22. Reads and automatically upgrade from fileformat v5.
@@ -475,7 +583,7 @@ None.
 * Using the Query Parser, it was not allowed to query on a property named 'desc'. ([#5723](https://github.com/realm/realm-core/issues/5723))
 
 ### Breaking changes
-* None.
+* None
 
 ### Compatibility
 * Fileformat: Generates files with format v22. Reads and automatically upgrade from fileformat v5.

diff --git a/Package.swift b/Package.swift
@@ -3,7 +3,7 @@
 import PackageDescription
 import Foundation
 
-let versionStr = "13.3.0"
+let versionStr = "13.5.0"
 let versionPieces = versionStr.split(separator: "-")
 let versionCompontents = versionPieces[0].split(separator: ".")
 let versionExtra = versionPieces.count > 1 ? versionPieces[1] : ""
@@ -93,7 +93,6 @@ let notSyncServerSources: [String] = [
  "realm/spec.cpp",
  "realm/status.cpp",
  "realm/string_data.cpp",
- "realm/sync/binding_callback_thread_observer.cpp",
  "realm/sync/changeset.cpp",
  "realm/sync/changeset_encoder.cpp",
  "realm/sync/changeset_parser.cpp",
@@ -115,6 +114,7 @@ let notSyncServerSources: [String] = [
  "realm/sync/noinst/client_reset_operation.cpp",
  "realm/sync/noinst/client_reset_recovery.cpp",
  "realm/sync/noinst/compact_changesets.cpp",
+ "realm/sync/noinst/migration_store.cpp",
  "realm/sync/noinst/pending_bootstrap_store.cpp",
  "realm/sync/noinst/protocol_codec.cpp",
  "realm/sync/noinst/sync_metadata_schema.cpp",

diff --git a/dependencies.list b/dependencies.list
@@ -1,5 +1,5 @@
 PACKAGE_NAME=realm-core
-VERSION=13.3.0
-OPENSSL_VERSION=3.0.7
+VERSION=13.5.0
+OPENSSL_VERSION=3.0.8
 WIN32_ZLIB_VERSION=1.2.13
-MDBREALM_TEST_SERVER_TAG=2023-01-19
+MDBREALM_TEST_SERVER_TAG=2023-02-18
diff --git a/evergreen/config.yml b/evergreen/config.yml
@@ -81,6 +81,10 @@ functions:
  set_cmake_var realm_vars REALM_ENABLE_ALLOC_SET_ZERO BOOL On
  fi
 
+ if [ -n "${enable_fuzzer|}" ]; then
+ set_cmake_var realm_vars REALM_LIBFUZZER BOOL On
+ fi
+
  if [ -z "${disable_sync|}" ]; then
  set_cmake_var realm_vars REALM_ENABLE_SYNC BOOL On
  fi
@@ -225,6 +229,35 @@ functions:
  display_name: install baas output
  optional: true
 
+ "upload fuzzer results":
+ - command: shell.exec
+ params:
+ working_dir: realm-core/build/test/realm-fuzzer
+ script: |-
+ if ls crash-*> /dev/null 2>&1; then
+ echo "Found crash file"
+ mv crash-* realm-fuzzer-crash.txt
+ fi
+
+ - command: s3.put
+ params:
+ working_dir: realm-core/build/test/realm-fuzzer
+ aws_key: '${artifacts_aws_access_key}'
+ aws_secret: '${artifacts_aws_secret_key}'
+ local_file: 'realm-core/build/test/realm-fuzzer/realm-fuzzer-crash.txt'
+ remote_file: '${project}/${branch_name}/${task_id}/${execution}/realm-fuzzer-crash.txt'
+ bucket: mciuploads
+ permissions: public-read
+ content_type: text/text
+ display_name: Fuzzer crash report
+ optional: true
+
+ - command: shell.exec
+ params:
+ working_dir: realm-core/build/test/realm-fuzzer
+ script: |-
+ rm realm-fuzzer-crash.txt
+
  "run hang analyzer":
  - command: shell.exec
  params:
@@ -592,7 +625,7 @@ tasks:
  export DEVELOPER_DIR="${xcode_developer_dir}"
  fi
 
- ./evergreen/install_baas.sh -w ./baas-work-dir -b 1e1df073f20bbf490c0f57086e890aa482855f61 2>&1 | tee install_baas_output.log
+ ./evergreen/install_baas.sh -w ./baas-work-dir -b 029b693c53074c29379a67789d6a56740b1aaef9 2>&1 | tee install_baas_output.log
  fi
 
  - command: shell.exec
@@ -659,6 +692,15 @@ tasks:
  echo $out
  exit 1
 
+- name: fuzzer
+ commands:
+ - command: shell.exec
+ params:
+ working_dir: realm-core/build/test/realm-fuzzer
+ shell: /bin/bash
+ script: |-
+ ${cmake_build_type|Debug}/realm-libfuzz -rss_limit_mb=0 -max_total_time=3600
+
 task_groups:
 - name: compile_test_and_package
  max_hosts: 1
@@ -730,6 +772,19 @@ task_groups:
  tasks:
  - long-running-core-tests
 
+- name: fuzzer-tests
+ setup_group_can_fail_task: true
+ setup_group:
+ - func: "fetch source"
+ - func: "fetch binaries"
+ - func: "compile"
+ vars:
+ target_to_build: realm-libfuzz
+ teardown_task:
+ - func: "upload fuzzer results"
+ tasks:
+ - fuzzer
+
 buildvariants:
 - name: ubuntu2004
  display_name: "Ubuntu 20.04 x86_64 (Clang 11)"
@@ -862,6 +917,26 @@ buildvariants:
  distros:
  - ubuntu2004-large
 
+- name: ubuntu2004-fuzzer
+ display_name: "Ubuntu 20.04 x86_64 (Clang 11 Fuzzer)"
+ run_on: ubuntu2004-large
+ expansions:
+ clang_url: "https://s3.amazonaws.com/static.realm.io/evergreen-assets/clang%2Bllvm-11.0.0-x86_64-linux-gnu-ubuntu-20.04.tar.xz"
+ cmake_url: "https://s3.amazonaws.com/static.realm.io/evergreen-assets/cmake-3.20.3-linux-x86_64.tar.gz"
+ cmake_bindir: "./cmake_binaries/bin"
+ fetch_missing_dependencies: On
+ run_tests_against_baas: On
+ enable_ubsan: On
+ c_compiler: "./clang_binaries/bin/clang"
+ cxx_compiler: "./clang_binaries/bin/clang++"
+ cmake_build_type: RelWithDebInfo
+ run_with_encryption: On
+ enable_fuzzer: On
+ tasks:
+ - name: fuzzer-tests
+ cron: "@daily"
+ patchable: true
+
 - name: rhel70
  display_name: "RHEL 7 x86_64"
  run_on: rhel70-small

diff --git a/evergreen/install_baas.sh b/evergreen/install_baas.sh
@@ -227,7 +227,7 @@ YARN="$WORK_PATH/yarn/bin/yarn"
 if [[ ! -x "$YARN" ]]; then
  echo "Getting yarn"
  mkdir yarn && cd yarn
- $CURL -LsS https://s3.amazonaws.com/stitch-artifacts/yarn/latest.tar.gz | tar -xz --strip-components=1
+ $CURL -LsS https://yarnpkg.com/latest.tar.gz | tar -xz --strip-components=1
  cd -
  mkdir "$WORK_PATH/yarn_cache"
 fi