Add handling of hex encoded key to realm-trawler #6264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnschiermer
force-pushed
the
fsa/trawler-handles-hexkeyformat
branch
from
541b0f7
to
c590514
Compare
jedelbo
requested changes
Feb 2, 2023
src/realm/exec/realm_trawler.cpp
Outdated
| @@ -1036,6 +1044,42 @@ void RealmFile::changes() const | |||
| } | |||
| } | |||
|
|
|||
| bool is_hex(char c) | |||
| std::ifstream key_file(argv[curr_arg + 1]); | ||
| key_file.read(key, sizeof(key)); | ||
| key_ptr = key; | ||
| curr_arg++; | ||
| } | ||
| else if (strcmp(argv[curr_arg], "--hexkey") == 0) { | ||
| curr_arg++; | ||
| const char* chars = argv[curr_arg]; |
There was a problem hiding this comment.
Perhaps we should have a check on the length here.
src/realm/exec/realm_trawler.cpp
Outdated
| return (hex_char_to_bin(first) << 4) | hex_char_to_bin(second); | ||
| } | ||
|
|
||
| char to_hex_char(char c) |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Add a new option "--hexkey <the-very-long-key>" to realm-trawler.
This option allows the trawler to get the key to an encrypted realm directly on the command line instead of via a binary file.