Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bson files to core utils #7157

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Move bson files to core utils #7157

merged 1 commit into from
Nov 21, 2023

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Nov 21, 2023

What, How & Why?

The bson library should be available to core/core as well

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link

Pull Request Test Coverage Report for Build github_pull_request_285276

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 892 unchanged lines in 35 files lost coverage.
  • Overall coverage decreased (-0.01%) to 91.644%

Files with Coverage Reduction New Missed Lines %
src/realm/util/compression.cpp 1 91.59%
src/realm/array_string.cpp 2 88.0%
src/realm/sync/subscriptions.hpp 2 16.13%
src/realm/sort_descriptor.cpp 3 93.7%
src/realm/sync/network/network.cpp 3 89.66%
src/realm/sync/noinst/protocol_codec.hpp 3 76.21%
test/object-store/util/test_file.hpp 3 94.83%
test/test_util_network.cpp 3 97.2%
test/object-store/c_api/c_api.cpp 4 99.48%
test/object-store/util/sync/sync_test_utils.hpp 4 76.32%
Totals Coverage Status
Change from base Build 1852: -0.01%
Covered Lines: 230757
Relevant Lines: 251796

💛 - Coveralls

@jedelbo jedelbo merged commit c61c304 into master Nov 21, 2023
@jedelbo jedelbo deleted the je/move-bson branch November 21, 2023 13:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants