Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing install headers #7165

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Add missing install headers #7165

merged 2 commits into from
Nov 24, 2023

Conversation

ironage
Copy link
Contributor

@ironage ironage commented Nov 23, 2023

The validate-install-headers job on realm-core-stable has been failing since #7157

No changelog, since this hasn't been released yet.

@ironage ironage self-assigned this Nov 23, 2023
Copy link

coveralls-official bot commented Nov 23, 2023

Pull Request Test Coverage Report for Build james.stone_429

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 82 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.007%) to 91.699%

Files with Coverage Reduction New Missed Lines %
src/realm/index_string.cpp 1 87.81%
src/realm/array_string.cpp 2 88.0%
src/realm/object-store/sync/sync_manager.cpp 2 86.58%
src/realm/sync/noinst/server/server_history.cpp 2 67.9%
src/realm/util/file.cpp 2 81.73%
src/realm/uuid.cpp 2 97.06%
test/test_sync.cpp 2 94.14%
src/realm/sync/noinst/protocol_codec.hpp 3 76.21%
src/realm/alloc_slab.cpp 5 92.89%
src/realm/sync/network/network.hpp 7 85.41%
Totals Coverage Status
Change from base Build 1860: 0.007%
Covered Lines: 231728
Relevant Lines: 252706

💛 - Coveralls

@kiburtse kiburtse self-requested a review November 23, 2023 22:00
@kiburtse
Copy link
Contributor

why don't we run this headers check on every pr for at least one builder? The check itself takes no time compared to compilation and especially baas tests...

@ironage
Copy link
Contributor Author

ironage commented Nov 23, 2023

@kiburtse I don't think we have anything to lose, I've added it to PR triggers in the latest commit.

@kiburtse kiburtse merged commit 8f55f1c into master Nov 24, 2023
2 checks passed
@kiburtse kiburtse deleted the js/fix-inst-bson branch November 24, 2023 10:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants