Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated flutter pub run #1294

Merged
merged 7 commits into from
Jun 15, 2023
Merged

Deprecated flutter pub run #1294

merged 7 commits into from
Jun 15, 2023

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented May 30, 2023

  • Deprecated flutter pub run
    flutter pub run is deprecated:

@desistefanova desistefanova requested review from blagoev and nielsenko and removed request for blagoev May 30, 2023 05:59
@desistefanova desistefanova marked this pull request as ready for review May 30, 2023 06:00
@desistefanova desistefanova added the no-changelog Used to skip the changelog check label May 30, 2023
@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 5118064767

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.285%

Totals Coverage Status
Change from base Build 5078382290: 0.0%
Covered Lines: 3133
Relevant Lines: 3509

💛 - Coveralls

Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge this into realm/realm-dart-samples#48 so we can review in one go?
Scratch that 🤦

Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is deprecated the command is still available. Since we support old versions of Flutter we should update this readme only after we remove the older Flutter version support.
Otherwise if you try to use dart command in a Flutter project you will get an error.

@nielsenko
Copy link
Contributor

nielsenko commented May 31, 2023

While it is deprecated the command is still available. Since we support old versions of Flutter we should update this readme only after we remove the older Flutter version support. Otherwise if you try to use dart command in a Flutter project you will get an error.

Actually not:

~/Projects/flutter/3.7.12/bin/flutter create not
❯ cd not
❯ ~/Projects/flutter/3.7.12/bin/flutter pub add realm
❯ ~/Projects/flutter/3.7.12/bin/dart run realm generate
Building package executable...
Built realm:realm.
[INFO] Generating build script...
[INFO] Generating build script completed, took 167ms

[INFO] Precompiling build script......
[INFO] Precompiling build script... completed, took 3.0s

[INFO] Initializing inputs
[INFO] Building new asset graph...
[INFO] Building new asset graph completed, took 384ms

[INFO] Checking for unexpected pre-existing outputs....
[INFO] Checking for unexpected pre-existing outputs. completed, took 0ms

[INFO] Running build...
[INFO] Generating SDK summary...
[INFO] 1.0s elapsed, 0/2 actions completed.
[INFO] 2.2s elapsed, 0/2 actions completed.
[INFO] Generating SDK summary completed, took 2.2s

[INFO] 3.2s elapsed, 0/2 actions completed.
[INFO] 7.3s elapsed, 0/2 actions completed.
[INFO] realm:realm_generator on lib/main.dart:[generate (0)] completed, took 334ms
[INFO] realm:realm_generator on test/widget_test.dart:[generate (0)] completed, took 1ms
[INFO] Running build completed, took 7.7s

[INFO] Caching finalized dependency graph...
[INFO] Caching finalized dependency graph completed, took 14ms

[INFO] Succeeded after 7.7s with 0 outputs (4 actions)

not even a warning

@blagoev
Copy link
Contributor

blagoev commented Jun 1, 2023

@nielsenko There is at least one Flutter version which requires a flutter run command instead of dart run

@desistefanova desistefanova changed the title Deprecated flutter pub run Bump version of Dart >=3.0.2 and Flutter >=3.10.2 Jun 2, 2023
@desistefanova desistefanova removed the no-changelog Used to skip the changelog check label Jun 2, 2023
@desistefanova desistefanova marked this pull request as draft June 2, 2023 16:23
@nielsenko
Copy link
Contributor

Did this PR change title and purpose?

@desistefanova
Copy link
Contributor Author

Did this PR change title and purpose?

Yes I changed it, but probably I will open another PR only for bumping versions. It is not finished yet. This is in draft.

flutter/realm_flutter/example/README.md Outdated Show resolved Hide resolved
flutter/realm_flutter/pubspec.yaml Outdated Show resolved Hide resolved
common/pubspec.yaml Outdated Show resolved Hide resolved
example/pubspec.yaml Outdated Show resolved Hide resolved
ffigen/pubspec.yaml Outdated Show resolved Hide resolved
flutter/realm_flutter/example/pubspec.yaml Outdated Show resolved Hide resolved
flutter/realm_flutter/pubspec.yaml Outdated Show resolved Hide resolved
flutter/realm_flutter/tests/pubspec.yaml Outdated Show resolved Hide resolved
@desistefanova desistefanova changed the title Bump version of Dart >=3.0.2 and Flutter >=3.10.2 Deprecated flutter pub run Jun 5, 2023
@desistefanova desistefanova added the no-changelog Used to skip the changelog check label Jun 5, 2023
@desistefanova desistefanova marked this pull request as ready for review June 6, 2023 07:16
flutter/realm_flutter/example/README.md Outdated Show resolved Hide resolved
flutter/realm_flutter/example/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does change the readme.md files but most importantly does NOT change our usage of flutter pub run anywhere in the build scripts.

Lets merge this as is and I can change the relevant places in the #1316 since it already changes the build scripts in order to avoid merge conflicts.

@desistefanova
Copy link
Contributor Author

This does change the readme.md files but most importantly does NOT change our usage of flutter pub run anywhere in the build scripts.

Lets merge this as is and I can change the relevant places in the #1316 since it already changes the build scripts in order to avoid merge conflicts.

@blagoev could you share what should be changed in the build script? I can't find such place in your PR?
If you meant the metrics command, it is still the same in #1316:
commandLine flutterExecutablePath, 'pub', 'run', 'realm', 'install', '--target-os-type', 'android', '--flavor', 'flutter'
This one should be fixed.

@blagoev
Copy link
Contributor

blagoev commented Jun 15, 2023

Lets merge this as is. The rest will be fixed in another PR

@desistefanova desistefanova merged commit ee862ac into main Jun 15, 2023
@desistefanova desistefanova deleted the ds/update_readme branch June 15, 2023 16:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants