-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated flutter pub run
#1294
Conversation
Pull Request Test Coverage Report for Build 5118064767
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you merge this into realm/realm-dart-samples#48 so we can review in one go?
Scratch that 🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it is deprecated the command is still available. Since we support old versions of Flutter we should update this readme only after we remove the older Flutter version support.
Otherwise if you try to use dart
command in a Flutter project you will get an error.
Actually not: ❯ ~/Projects/flutter/3.7.12/bin/flutter create not
❯ cd not
❯ ~/Projects/flutter/3.7.12/bin/flutter pub add realm
❯ ~/Projects/flutter/3.7.12/bin/dart run realm generate
Building package executable...
Built realm:realm.
[INFO] Generating build script...
[INFO] Generating build script completed, took 167ms
[INFO] Precompiling build script......
[INFO] Precompiling build script... completed, took 3.0s
[INFO] Initializing inputs
[INFO] Building new asset graph...
[INFO] Building new asset graph completed, took 384ms
[INFO] Checking for unexpected pre-existing outputs....
[INFO] Checking for unexpected pre-existing outputs. completed, took 0ms
[INFO] Running build...
[INFO] Generating SDK summary...
[INFO] 1.0s elapsed, 0/2 actions completed.
[INFO] 2.2s elapsed, 0/2 actions completed.
[INFO] Generating SDK summary completed, took 2.2s
[INFO] 3.2s elapsed, 0/2 actions completed.
[INFO] 7.3s elapsed, 0/2 actions completed.
[INFO] realm:realm_generator on lib/main.dart:[generate (0)] completed, took 334ms
[INFO] realm:realm_generator on test/widget_test.dart:[generate (0)] completed, took 1ms
[INFO] Running build completed, took 7.7s
[INFO] Caching finalized dependency graph...
[INFO] Caching finalized dependency graph completed, took 14ms
[INFO] Succeeded after 7.7s with 0 outputs (4 actions) not even a warning |
@nielsenko There is at least one Flutter version which requires a |
flutter pub run
Did this PR change title and purpose? |
Yes I changed it, but probably I will open another PR only for bumping versions. It is not finished yet. This is in draft. |
flutter pub run
163f382
to
7548184
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does change the readme.md files but most importantly does NOT change our usage of flutter pub run
anywhere in the build scripts.
Lets merge this as is and I can change the relevant places in the #1316 since it already changes the build scripts in order to avoid merge conflicts.
@blagoev could you share what should be changed in the build script? I can't find such place in your PR? |
Lets merge this as is. The rest will be fixed in another PR |
flutter pub run
flutter pub run
is deprecated:To be merged after "Bump version of Dart >=3.0.2 and Flutter >=3.10.2"