Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle id sync conn #1316

Merged
merged 13 commits into from
Jun 15, 2023
Merged

bundle id sync conn #1316

merged 13 commits into from
Jun 15, 2023

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Jun 10, 2023

Bumps AGP versions
Don't use jcenter anymore
Fixes android build groovy scripts
Adds bundle id sync conn

@cla-bot cla-bot bot added the cla: yes label Jun 10, 2023
@blagoev blagoev added the no-changelog Used to skip the changelog check label Jun 10, 2023
@coveralls
Copy link

coveralls commented Jun 10, 2023

Pull Request Test Coverage Report for Build 5235549170

  • 11 of 29 (37.93%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 88.986%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/native/realm_core.dart 11 29 37.93%
Files with Coverage Reduction New Missed Lines %
lib/src/native/realm_core.dart 1 90.07%
Totals Coverage Status
Change from base Build 5212207263: -0.2%
Covered Lines: 3159
Relevant Lines: 3550

💛 - Coveralls

@blagoev blagoev marked this pull request as ready for review June 11, 2023 12:54
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of extra cleanup here as well, but the stuff about stamping the pubspec.yaml name attribute into the exe looks good to me, even if it seems odd we cannot read this from some standard place.

@@ -5,7 +5,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:4.1.0'
classpath 'com.android.tools.build:gradle:7.3.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After increasing the version, there is a compile message in Android studio

The option 'android.enableR8' is deprecated.
It was removed in version 7.0 of the Android Gradle plugin.
Please remove it from `gradle.properties`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a warning coming from our flutter\example. I don't think it is crucial to anything

@blagoev blagoev merged commit 2248ae2 into main Jun 15, 2023
@blagoev blagoev deleted the blagoev/bundle_id-sync-conn branch June 15, 2023 07:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants