-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kn/update analyzer #1365
kn/update analyzer #1365
Conversation
bfa483f
to
bcc8d4f
Compare
b199523
to
f6a9579
Compare
I see, that the sdk version is increased here in order to force using the new analyzer, but I think we should wait until there is a solution on the Linux issue with the new flutter. |
f6a9579
to
90fbf2b
Compare
90fbf2b
to
c11d70d
Compare
I tend to disagree. Very few people a using realm on linux, even fewer is using it outside flutter. They can always use realm 1.4.0 together with Dart 3.0.x. Once Dart team release a fix for dart-lang/sdk#53267, they can update at will. |
029c14a
to
5ccd431
Compare
5ccd431
to
7148ac5
Compare
@nirinchev The linux issue holding this back has been fixed. |
@nirinchev Sorry, you need to revert 6abe028 which is a temporary fix I did. Note that this PR will force users of the next version to use Flutter 3.13.0 or later (which is latest stable major) to get Dart 3.1.0+ |
Hi @nielsenko, when can we expect this PR to be merged ? We are waiting for this issue to be resolved |
@sagnik-sanyal I've taken over this PR and expect to merge it soon. The reason why it's delayed is because I want to check how many users will be impacted by the flutter upgrade. |
Based on our metrics, around 13% of our users are running on dart 3.1.0+. I'm a little hesitant to force the upgrade at this point unless you folks feel very confident that the flutter community is comfortable with always running latest and greatest. |
* main: kn/update analyzer (#1365)
👍 |
* main: Don't add the ISRG X1 Root on Android (#1434) Wait for initial sync to complete before starting the tests (#1435) kn/update analyzer (#1365) Add vNext Changelog header (#1429) [Release 1.6.0] (#1428) Upgrade to Core 13.23.4 (#1427) Flexible sync subscribe/unsubscribe API (#1354) Use default context rather than creating a new one (#1426) Handle duplicate certificates (#1425) kn/add certificate (#1378) asymmetric object allow non embedded links (#1402) Rudimentary geospatial support (#1389) Core 13.20.1 sync errors changes (#1387) Fix RealmObject.hashCode (#1420) add 'ignore_for_file: type=lint' to *.g.dart files (#1413) kn/fix skip then iterate bug (#1410)
Fix: #1357