Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add the ISRG X1 Root on Android #1434

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Don't add the ISRG X1 Root on Android #1434

merged 5 commits into from
Nov 29, 2023

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Nov 23, 2023 •
edited
Loading

Fixes #1430

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Nov 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7039346540

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 2 of 7 (28.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on ni/certificate at 88.367%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/app.dart 2 7 28.57%
Totals Coverage Status
Change from base Build 7027644373: 88.4%
Covered Lines: 3464
Relevant Lines: 3920
💛 - Coveralls

@nirinchev nirinchev changed the title Try to trigger the certificate issue Don't add the ISRG Root X1 on Android Nov 29, 2023
@nirinchev nirinchev changed the title Don't add the ISRG Root X1 on Android Don't add the ISRG X1 Root on Android Nov 29, 2023
@nirinchev nirinchev merged commit 2355f74 into main Nov 29, 2023
20 checks passed
@nirinchev nirinchev deleted the ni/certificate branch November 29, 2023 22:34
nirinchev added a commit that referenced this pull request Nov 30, 2023
@nirinchev
Merge branch 'main' into kn/realm-maps
5dcc0ad 
* main:
  Don't add the ISRG X1 Root on Android (#1434)
  Wait for initial sync to complete before starting the tests (#1435)
  kn/update analyzer (#1365)
  Add vNext Changelog header (#1429)
  [Release 1.6.0] (#1428)
  Upgrade to Core 13.23.4 (#1427)
  Flexible sync subscribe/unsubscribe API (#1354)
  Use default context rather than creating a new one (#1426)
  Handle duplicate certificates (#1425)
  kn/add certificate (#1378)
  asymmetric object allow non embedded links (#1402)
  Rudimentary geospatial support (#1389)
  Core 13.20.1 sync errors changes (#1387)
  Fix RealmObject.hashCode (#1420)
  add 'ignore_for_file: type=lint' to *.g.dart files (#1413)
  kn/fix skip then iterate bug (#1410)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@nirinchev nirinchev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Realm: HTTP Transport: Exception executing get https://realm.mongodb.com/api/client/v2.0/app/{appId}/location
1 participant
@nirinchev