Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDART-1022: Drop x86 as target #1682

Merged
merged 9 commits into from
May 23, 2024
Merged

RDART-1022: Drop x86 as target #1682

merged 9 commits into from
May 23, 2024

Conversation

nielsenko
Copy link
Contributor

Reduce android bundle size.

There is no need to build for x86 as flutter itself does not support it.

Fixes: #1670

@nirinchev
Copy link
Member

Needs an update to the gha workflows it seems.

@nielsenko nielsenko changed the title Drop x86 as target RDART-1022: Drop x86 as target May 23, 2024
@nielsenko nielsenko marked this pull request as ready for review May 23, 2024 06:51
@nielsenko nielsenko changed the base branch from main to kn/update-core May 23, 2024 06:52
Base automatically changed from kn/update-core to main May 23, 2024 07:14
@nielsenko nielsenko merged commit 4f55de7 into main May 23, 2024
58 of 60 checks passed
@nielsenko nielsenko deleted the kn/drop-x86 branch May 23, 2024 07:15
nirinchev added a commit that referenced this pull request May 27, 2024
* main: (37 commits)
  RDART-930: Refactor handles (#1550)
  Forgot to show GeoPolygon
  Add vNext Changelog header (#1687)
  [Release 2.3.0] (#1686)
  RDART-1028: Use Zone.current.bindUnaryCallbackGuarded for RawReceivePort.handler (#1683)
  RDART-1021: Wire up some basic dynamic setting and change notifications (#1669)
  RDART-1022: Drop x86 as target (#1682)
  RDART-1034: Update realm-core to v14.7.0 (#1681)
  Skip select test
  RDART-1018: Fix badly generated _fromJson (#1664)
  Add vNext Changelog header (#1660)
  [Release 2.2.1] (#1659)
  Update CHANGELOG.md
  RDART-1016: Cleanup iOS podspec (#1658)
  Add vNext Changelog header (#1655)
  [Release 2.2.0] (#1654)
  RDART-1015: Update core to v14.6.2 (#1651)
  RDART-950: Update nullability annotations for base url API (#1652)
  RDART-964: Add PrivacyInfo.xcprivacy for iOS and macOS (#1646)
  RDART-1014: Bump required sdk version to ^3.3.0 (#1648)
  ...

# Conflicts:
#	CHANGELOG.md
#	packages/realm_dart/lib/src/native/realm_core.dart
#	packages/realm_dart/src/realm-core
#	packages/realm_dart/test/realm_test.dart
#	packages/realm_dart/test/session_test.dart
#	packages/realm_dart/test/test.dart
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Realm binary files take a lot of space in apk file, and include binary files for non-target platform.
3 participants