Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDART-1028: Use Zone.current.bindUnaryCallbackGuarded for RawReceivePort.handler #1683

Merged
merged 3 commits into from
May 23, 2024

Conversation

nielsenko
Copy link
Contributor

Fixes: #1676

@nielsenko
Copy link
Contributor Author

I'm a little lost as how to test this automatically on CI, but it works in my reproduction project.

@nielsenko nielsenko force-pushed the kn/fix-scheduler-callback-handler branch from a9a05c9 to fac3ed3 Compare May 22, 2024 17:38
@nielsenko nielsenko force-pushed the kn/fix-scheduler-callback-handler branch from fac3ed3 to 94224d8 Compare May 22, 2024 20:14
@nielsenko nielsenko force-pushed the kn/fix-scheduler-callback-handler branch from ad4a686 to 3e0993a Compare May 23, 2024 09:02
@nielsenko nielsenko marked this pull request as ready for review May 23, 2024 09:03
@nielsenko nielsenko changed the title Use Zone.current.bindUnaryCallbackGuarded for RawReceivePort.handler RDART-1028: Use Zone.current.bindUnaryCallbackGuarded for RawReceivePort.handler May 23, 2024
Copy link

Pull Request Test Coverage Report for Build 9205222843

Details

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 86.535%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/realm_dart/lib/src/scheduler.dart 9 10 90.0%
Totals Coverage Status
Change from base Build 9204562565: 0.002%
Covered Lines: 5893
Relevant Lines: 6810

💛 - Coveralls

@nielsenko nielsenko merged commit 86ad06c into main May 23, 2024
57 of 58 checks passed
@nielsenko nielsenko deleted the kn/fix-scheduler-callback-handler branch May 23, 2024 09:21
nirinchev added a commit that referenced this pull request May 27, 2024
* main: (37 commits)
  RDART-930: Refactor handles (#1550)
  Forgot to show GeoPolygon
  Add vNext Changelog header (#1687)
  [Release 2.3.0] (#1686)
  RDART-1028: Use Zone.current.bindUnaryCallbackGuarded for RawReceivePort.handler (#1683)
  RDART-1021: Wire up some basic dynamic setting and change notifications (#1669)
  RDART-1022: Drop x86 as target (#1682)
  RDART-1034: Update realm-core to v14.7.0 (#1681)
  Skip select test
  RDART-1018: Fix badly generated _fromJson (#1664)
  Add vNext Changelog header (#1660)
  [Release 2.2.1] (#1659)
  Update CHANGELOG.md
  RDART-1016: Cleanup iOS podspec (#1658)
  Add vNext Changelog header (#1655)
  [Release 2.2.0] (#1654)
  RDART-1015: Update core to v14.6.2 (#1651)
  RDART-950: Update nullability annotations for base url API (#1652)
  RDART-964: Add PrivacyInfo.xcprivacy for iOS and macOS (#1646)
  RDART-1014: Bump required sdk version to ^3.3.0 (#1648)
  ...

# Conflicts:
#	CHANGELOG.md
#	packages/realm_dart/lib/src/native/realm_core.dart
#	packages/realm_dart/src/realm-core
#	packages/realm_dart/test/realm_test.dart
#	packages/realm_dart/test/session_test.dart
#	packages/realm_dart/test/test.dart
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argument value for 'return_value' is null
2 participants