Samples and tests updated with relaxed final constraint for primary keys and properties #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blagoev
suggested changes
Feb 11, 2022
fix tests
test only on Linux
…into samples_updated
desistefanova
changed the base branch from
master
to
throw-error-on-primaryKey-set
blagoev
reviewed
Feb 14, 2022
blagoev
reviewed
Feb 14, 2022
blagoev
suggested changes
Feb 14, 2022
Co-authored-by: blagoev <lubo@blagoev.com>
Pull Request Test Coverage Report for Build 1841200469
💛 - Coveralls |
blagoev
approved these changes
Feb 14, 2022
blagoev
added a commit
that referenced
this pull request
Feb 17, 2022
* remove commented notifications code * refactor scheduler * rerun tests * randomize tests * wait a bit longer for callback * Randomize test execution ordering (#249) Dart tests configured to be executed in random order. * throw error on primary key set (#253) * throw error on primary key set * relax final on collections fix tests * fix setters in generated constructor to use RealmObject.set directly * fix generator tests * run realm_dart tests on generator change. test only on Linux * fix working directory * fix workflow * fix coverage file path * get submodule * clarify readme (#256) * clarify readme * fix link * handle PR feedback * fix code samples * fix error install command message (#246) * run CI on every change (#257) * run CI on every change * use stable channel on CI * Samples and tests updated with relaxed final constraint for primary keys and properties (#248) Samples updated not to require final for properties, primary keys and lists when generating models. * isValid of realm list and object (#183) * Realm object isValid and realm list isValid implementation * Tests added for property isValid of RealmList and RealmObject * fix scheduler
blagoev
added a commit
that referenced
this pull request
Feb 18, 2022
* Add notifications to RealmResults * Remove GC debug code that causes flutter macos build to fail * Rename changed to changes * Dart specific C api for notification callbacks * Fix ios build * Update bindings * Use new dart specific c-api for results notifications * Results notifications (#242) * fixup results notifications * fix results type constraints * use stable channel on CI * Remove callback_bridge.dart and controller_builder.dart (not needed for this PR anymore) * Update public API * Update README and CHANGELOG regarding RealmResults.changes * Refactor scheduler (#259) * remove commented notifications code * refactor scheduler * rerun tests * randomize tests * wait a bit longer for callback * Randomize test execution ordering (#249) Dart tests configured to be executed in random order. * throw error on primary key set (#253) * throw error on primary key set * relax final on collections fix tests * fix setters in generated constructor to use RealmObject.set directly * fix generator tests * run realm_dart tests on generator change. test only on Linux * fix working directory * fix workflow * fix coverage file path * get submodule * clarify readme (#256) * clarify readme * fix link * handle PR feedback * fix code samples * fix error install command message (#246) * run CI on every change (#257) * run CI on every change * use stable channel on CI * Samples and tests updated with relaxed final constraint for primary keys and properties (#248) Samples updated not to require final for properties, primary keys and lists when generating models. * isValid of realm list and object (#183) * Realm object isValid and realm list isValid implementation * Tests added for property isValid of RealmList and RealmObject * fix scheduler * fix public API * revert multiple tests on linux remove dead code * fix up public api docs * fix tests * fix name * refactor Results notifications * fix wording, samples in readmem, changelog Co-authored-by: blagoev <lubo@blagoev.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
finalfrom properties, primary keys and lists in realm models.Realm objects are regenerated.
All the tests and samples are tested with the new models.